Re: back-tab locks up 0.17.3 in Windows, with fix

[Scott Klement <tn5250@xxxxxxxxxxxxxxxx>]

Hi Buck,

Row 7 column 11 is not an input field on my display.  When I hit 
Shift-Tab, it goes to the "Position to" field, and does not lock up.

The reason it says that the file was removed is because James Rich 
reorganized all of the source code in the project back in 2006.  Instead 
of having a "src" directory, he put all of the source code for lib5250 
into a lib5250 directory, all of the source code for cursesterm into a 
curses directory, all of the source code for slangterm into a slang 
directory, etc, etc.  it made more sense than putting it all in one src 
directory where you didn't know what belonged to what.

In CVS, the way you make changes like that is to delete it from one 
directory and add it to another.  So you are looking at the old version 
from before the changes.

The current version can be found here:
http://tn5250.cvs.sourceforge.net/viewvc/*checkout*/tn5250/tn5250/lib5250/display.c?revision=1.6

The code in that source file does not seem to fit the patch you've 
provided.  Is it possible that you're looking at a very outdated copy of 
the source?  Do you have the same problem if you use the current copy?


Buck wrote:
> Here's the scenario:
> Start tn5250, sign on to System i.
> wrkmbrpdm
> Position cursor to row 7, column 11.  This is the first character of the
> member name column.
> Shift-tab.
> Lock up.
>
> I believe there's a missing 'break;' in
> tn5250_display_set_cursor_prev_progression_field
>
> Would appreciate a second set of eyes, although it works OK here.
> Although I used the diff from Cygwin, I'm using make from Mingw/Msys.
>
> Also, browsing in CVS, it says the source files are dead/removed.
> http://tn5250.cvs.sourceforge.net/viewvc/tn5250/tn5250/src/display.c?hideattic=0&revision=1.74&view=markup
> start around line 940 or search for 'differentfieldfound = 1;'
>   --buck
>
> $ diff -bur /cygdrive/c/tn5250-0.17.3/src/display.c
> /cygdrive/c/tn5250-0.17.3/src/display_1.74.c
>
> --- /cygdrive/c/tn5250-0.17.3/src/display.c     2008-11-18
> 14:35:03.265625000 -0500
> +++ /cygdrive/c/tn5250-0.17.3/src/display_1.74.c        2008-11-18
> 14:34:13.218000000 -0500
> @@ -957,7 +957,6 @@
>        else
>         {
>           differentfieldfound = 1;
> -         break;
>         }
>
>        if (field->nextfieldprogressionid == currentfield)