Re: Passing a MODS as a parameter

Comments in-line Frank.

On Feb 14, 2020, at 4:09 AM, Frank Kolmann <frank.kolmann@xxxxxxxxx> wrote:

Thanks Jon and Brigitta

Thank you Jon.
I am quite aware how to process MODS.

Sorry if I gave the impression that I was trying to teach granny to suck eggs. I try to answer for the whole audience that might read the post and this is a common problem.

I passed the pointer to the MODS as a parameter.

Makes more work than just passing the actual DS but ...

This worked. I was able to process the MODS fine. Now this no longer works, something has changed,

However, btw, I recoded to use an Array DS.
Well I am getting back ONLY the first DS(1), the first DS array element. The rest are empty.
I know that I am populating the DS array, I can see that in debug,

Appreciate any suggestion as to what I am doing wrong.


Code fragment of the PR and PI of the called progrzm

D RtvFlds PR N
D QDspFil 20A Value
D QNumFlds 10I 0
D QFlddta Like(FDS) Dim(2000)

This next DS definition doesn't seem needed and I don't see where you are setting p_FDS either. Or are you just using it as a template? In which case remove the Based and Qualified bits and add Template.

You're not showing how you populate the fields but the targets should all be QFlddta(n).fieldname

Are you perhaps getting back the _last_ entry not the first? i.e. are you perhaps constantly overwriting element 1?

There is nothing inherent here that I can see that could conceivably cause the symptoms you describe so we need to at least see an outline of how the DS is being populated.

D FDS DS Based (p_FDS) qualified dim(2000)
D #FmtNam 10A
D #FldNam 10A
D #FldLen 5I 0
D #FldPlen 5I 0
D #FldDec 1
D #FldIO 1
D #FldAtr 1
D #FldDTUS 1
D #FldEdt 20A
D #FldRow 10I 0
D #FldCol 10I 0
D #FldCom 4000A varying
*---------------------------------------------------------------*
* Retrieve Display File Fields *
*---------------------------------------------------------------*

P RtvFlds B Export



D RtvFlds PI Like(LglTyp)
D QDspFil Like( QNamTyp ) Value
D Numflds 10I 0
D FldDta Like(FDS) dim(2000)

In debug I can see FldDta has the correct information



Code from caller

D FDS DS QUALIFIED DIM(2000)

D #FmtNam 10A
D #FldNam 10A
D #FldLen 5I 0
D #FldPlen 5I 0
D #FldDec 1
D #FldIO 1
D #FldAtr 1
D #FldDTUS 1
D #FldEdt 20A
D #FldRow 10I 0
D #FldCol 10I 0
D #FldCom 1000A varying



D RTVFLDS PR N
D $FilQul 20 Value
D $NumFlds 10I 0
D $FldDtaDS Like(FDS) dim(2000)

*IN10 = RTVFLDS ($FilQul : #GotFlds : FDS);

In debug I can see that FDS has only the first element of the DS populated, all the rest are empty.

This is the first time I used DS arrays, and from what I see the same problem exists as the MODS problem.

Regards
Frank




On 13/02/2020 2:36 am, Jon Paris wrote:

Actually what is passed is the address of whatever occurrence was set at the time of the call.
If you did an Occur 1 before the call then it is the address of the first element.
Had you done some processing that left the current occurrence at (say) 20 before the call then the address of 20 would be passed.

The only way to process a MODS correctly when passed as a parm is to increment the occurrence_within_ the called routine.

But Birgitta is right - you should be using a DS array which will avoid all of the messiness. Basically MODS are deprecated - DS arrays are a much better approach.

On Feb 11, 2020, at 11:42 PM, Frank Kolmann<frank.kolmann@xxxxxxxxx> wrote:

Hi

A while back I wrote a program that uses QDFRTVFD api.
source is here
https://wiki.midrange.com/index.php/QDFRTVFD_%E2%80%94_Retrieve_Display_File_Description

--
This is the RPG programming on IBM i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

Help support midrange.com by shopping at amazon.com with our affiliate link: https://amazon.midrange.com