Re: Passing a MODS as a parameter

Thanks Jon and Brigitta

Thank you Jon.
I am quite aware how to process MODS.
I passed the pointer to the MODS as a parameter.
This worked.   I was able to process the MODS fine.  Now this no longer works, something has changed,

However, btw,  I recoded to use an Array DS.
Well  I am getting back ONLY the first  DS(1),  the first DS array element.  The rest are empty.
I know that I am populating the DS array, I can see that in debug,

Appreciate any suggestion as to what I am doing wrong.


Code fragment of the PR and PI  of the called progrzm

   D RtvFlds         PR              N
     D  QDspFil                      20A    Value
     D  QNumFlds                     10I 0
     D  QFlddta                             Like(FDS) Dim(2000)

     D FDS             DS                  Based (p_FDS) qualified dim(2000)
     D  #FmtNam                      10A
     D  #FldNam                      10A
     D  #FldLen                       5I 0
     D  #FldPlen                      5I 0
     D  #FldDec                       1
     D  #FldIO                        1
     D  #FldAtr                       1
     D  #FldDTUS                      1
     D  #FldEdt                      20A
     D  #FldRow                      10I 0
     D  #FldCol                      10I 0
     D  #FldCom                    4000A   varying
*---------------------------------------------------------------*
      *  Retrieve Display File Fields                                 *
*---------------------------------------------------------------*

     P RtvFlds         B                   Export



     D  RtvFlds        PI                  Like(LglTyp)
     D  QDspFil                            Like( QNamTyp ) Value
     D  Numflds                      10I 0
     D  FldDta                             Like(FDS) dim(2000)

In debug I can see FldDta has the correct information



Code from caller

     D FDS             DS                  QUALIFIED DIM(2000)

     D  #FmtNam                      10A
     D  #FldNam                      10A
     D  #FldLen                       5I 0
     D  #FldPlen                      5I 0
     D  #FldDec                       1
     D  #FldIO                        1
     D  #FldAtr                       1
     D  #FldDTUS                      1
     D  #FldEdt                      20A
     D  #FldRow                      10I 0
     D  #FldCol                      10I 0
     D  #FldCom                    1000A   varying



     D RTVFLDS         PR              N
     D  $FilQul                      20    Value
     D  $NumFlds                     10I 0
     D  $FldDtaDS                          Like(FDS) dim(2000)

    *IN10 = RTVFLDS ($FilQul : #GotFlds    : FDS);

In debug I can see that FDS  has only the first element of the DS populated, all the rest are empty.

This is the first time I used DS arrays, and from what I see the same problem exists as the MODS problem.

Regards
Frank




On 13/02/2020 2:36 am, Jon Paris wrote:

Actually what is passed is the address of whatever occurrence was set at the time of the call.
If you did an Occur 1 before the call then it is the address of the first element.
Had you done some processing that left the current occurrence at (say) 20 before the call then the address of 20 would be passed.

The only way to process a MODS correctly when passed as a parm is to increment the occurrence_within_ the called routine.

But Birgitta is right - you should be using a DS array which will avoid all of the messiness. Basically MODS are deprecated - DS arrays are a much better approach.

On Feb 11, 2020, at 11:42 PM, Frank Kolmann<frank.kolmann@xxxxxxxxx> wrote:

Hi

A while back I wrote a program that uses QDFRTVFD api.
source is here
https://wiki.midrange.com/index.php/QDFRTVFD_%E2%80%94_Retrieve_Display_File_Description