× The internal search function is temporarily non-functional. The current search engine is no longer viable and we are researching alternatives.
As a stop gap measure, we are using Google's custom search engine service.
If you know of an easy to use, open source, search engine ... please contact support@midrange.com.


  1.  Home
  2. RPG400-L
  3. January 2018

Re: Question about dcl-proc

Consistency is near and dear to me. Looking at a contract programmers code last night and there are three "if" statements in spitting distance of one another. You can see all in one green screen.

He got 3 of 4 possible case combinations. Just missing the all caps version. Aaarrrggghh.

Two blocks no indentation and one indented one space which is barely distinguishable.

We had a chat about that...



Sent from my Galaxy Tab® A


-------- Original message --------
From: john erps <jacobus.erps@xxxxxxxxx>
Date: 1/16/18 7:57 AM (GMT-08:00)
To: "RPG programming on the IBM i (AS/400 and iSeries)" <rpg400-l@xxxxxxxxxxxx>
Subject: Re: Question about dcl-proc

I like the code to be consistent.

Besides, it's not that much work actually; it's not difficult to make a
program that does the work.

On Tue, Jan 16, 2018 at 4:51 PM, Vernon Hamberg <vhamberg@xxxxxxxxxxxxxxx>
wrote:

+1


On 1/16/2018 9:40 AM, Mark Murphy wrote:

I would say that's not worth it unless you have nothing better to do.
Where
I am working, we have a wide ranging mix of styles, and while I don't
prefer most of them, there is nothing about them that causes them to
compile any better or worse than some other style. If I am working on a
procedure that is particularly heinous, I might reformat it. Otherwise, I
have better things to do.

On Tue, Jan 16, 2018 at 3:40 AM, john erps <jacobus.erps@xxxxxxxxx>
wrote:

Ok.

Thanks for the responses everyone.

It's clear what i need to do.... update 100's of procedures (yes auto
formatting but no).



On Tue, Jan 16, 2018 at 1:16 AM, Stuart Rowe <rowestu@xxxxxxxxx> wrote:

I like to indent the pi simply because it makes the dcl-pi and end-pi

line

up (right adjusted) under the dcl-proc.



On Mon, Jan 15, 2018 at 12:48 PM, Mark Murphy <jmarkmurphy@xxxxxxxxx>
wrote:

The parm is part of the dcl-pi block, so it's indented wrt this

block.

The block itself is part of the dcl-proc, so strictly it would have

to

be

indented wrt dcl-proc.
But then the body (i.e. the part after dcl-pi) should be indented

like:

dcl-proc

dcl-pi
dcl-end

-body-

dcl-s field ind;

end-proc

Not sure I follow with this. The -body- is not part of the dcl-pi

block,

therefore, it should not be indented wrt to the pi block. And I am

pretty

sure you can not put the body ahead of the other declarations within a
procedure.

I prefer the RDi way:

dcl-proc
dcl-pi
end-pi

-additional declarations-

-body-

end-proc

On Mon, Jan 15, 2018 at 4:59 AM, john erps <jacobus.erps@xxxxxxxxx>

wrote:

The parm is part of the dcl-pi block, so it's indented wrt this

block.

The block itself is part of the dcl-proc, so strictly it would have

to

be

indented wrt dcl-proc.
But then the body (i.e. the part after dcl-pi) should be indented

like:

dcl-proc

dcl-pi
dcl-end

-body-

dcl-s field ind;

end-proc

but this more practical (and clearer):

dcl-proc
dcl-pi
dcl-end

-body-

dcl-s field ind;

end-proc

The dcl-proc and dcl-pi constructs shoud have been one declaration
construct.




On Mon, Jan 15, 2018 at 10:29 AM, <j.beckeringh@pantheon-

automatisering.nl

wrote:

Hi John,

To me it is quite simple: procedure interface has its own keywords

for

start and end, which should be placed between start and end of

procedure

declaration. So they should be indented.

Isn't the parm-line between dcl-pi and end-pi part of the procedure
interface? So why is that one indented?

Maybe the dcl-proc could have been implemented more like other

languages

as:

dcl-proc Proc (parm char(1) value) ind;

But it wasn't :-)

Joep Beckeringh
Software architect
Pantheon Automatisering B.V.
Heerenveen

john erps <jacobus.erps@xxxxxxxxx>

15-01-2018 10:10

Question about dcl-proc

Hi,

I notice that many specify a procedure as follows:

dcl-proc Proc;

dcl-pi *n ind;
parm char(1) value;
end-pi;

code (procedure body) follows

dcl-s x ind;

...

end-proc;

Instead of:

dcl-proc Proc;
dcl-pi *n ind;
parm char(1) value;
end-pi;

code (procedure body) follows

dcl-s x ind;

...

end-proc;

The difference being that in the first example the dcl-pi part

has

the

same

indentation level as the procedure body. For me it would seem

that

the

second example is more logical, because dcl-pi is part of the

procedure

declaration, not part of the procedure body, and should have the
indentation level of the procedure declaration.

Any thoughts?

--
This is the RPG programming on the IBM i (AS/400 and iSeries)

(RPG400-L)

mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our

affiliate

link: http://amzn.to/2dEadiD

--
This is the RPG programming on the IBM i (AS/400 and iSeries)

(RPG400-L)

mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our

affiliate

link: http://amzn.to/2dEadiD

--
This is the RPG programming on the IBM i (AS/400 and iSeries)

(RPG400-L)

mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD


--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

Help support midrange.com by shopping at amazon.com with our affiliate link: http://amzn.to/2dEadiD

As an Amazon Associate we earn from qualifying purchases.

This thread ...
Follow-Ups:
Replies:
Follow On AppleNews
Return to Archive home page | Return to MIDRANGE.COM home page

This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].

Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.