Re: RPG Refactoring - removing GOTO - tips & techniques?

On 12 Oct 2017, at 18:43, Charles Wilt <charles.wilt@xxxxxxxxx> wrote:

Looking at an old program that using GOTO...I'd like to get rid of it.

In this case, it's a relatively simple usage

//mainline part1
if something goto @end
//mainline part2
if somethingelse goto @end
//mainline part 3
...
TAG @END
eval parm12 = *IN12;
return;

I see two options
1) dou loop
2) add an end_program subroutine

---Option 1---

dou *on = *on; //run once
//mainline part1
if something leave
//mainline part2
if somethingelse leave
//mainline part 3
enddo;
eval parm12 = *IN12;
return;

---Option 2---

//mainline part1
if something exsr @END_PROGRAM
//mainline part2
if somethingelse exsr @END_PROGRAM
//mainline part 3
...
exsr @END_PROGRAM
//shouldn't get here, but to be safe
return;

begsr @END_PROGRAM;
eval parm12 = *IN12;
return;
endsr;


Advantages to option 2 as I see them...
- works even if GOTO exists in a loop in the mainline
- works if GOTO is in an subroutine

note that the "eval parm12 = *IN12" line is due to refactoring a *ENTRY
PLIST into a PR/PI. *IN12 was specified as the factor 2 on the PARM
op-code for parm12. So I can't just change GOTO @END to RETURN.

Thoughts / comments on either of the above options?
Any additional tips or techniques?

Thanks!
Charles
--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

Help support midrange.com by shopping at amazon.com with our affiliate link: http://amzn.to/2dEadiD