RE: trying to be modular

-----Message d'origine-----
[mailto:rpg400-l-bounces@xxxxxxxxxxxx] De la part de
Lennon_s_j@xxxxxxxxxxx

From what I see, there is vast sharing of global data going
on. (Paul's comment on coupling is on the mark.) Personally,
I dislike sharing global data. I'd much rather see this in a
service program.

This is an attempt at modularising my code. At the risk of

getting slammed, I ask if it is acceptable and to tell me
what the disadvantages may be and how I should have done this.

Had to get an authorization level from a user information

table to condition a screen indicator in an existing program.
The user table contains lots of other information like name,
department and telephone number, etc.

In my pgm :

// *IN49 is already on.

IF GetAutLevel>= '4';
*IN49 = *OFF;

ENDIF;


In a separate module where the user table is already used,

I added :

P GetAutLevel B EXPORT
D PI LIKE ( DFN_AUTLV )
D UserId LIKE ( DFN_USRID ) CONST
D Error LIKE ( DFN_ERRMG )

D wAutLv S LIKE ( DFN_AUTLV )

IF NOT SetUserInfo ( UserId : Error );
RETURN *BLANK;

ENDIF;

RETURN UAUTNV; // From user table

P GetAutLevel E




P SetUserInfo B
D PI N
D UserId LIKE ( DFN_USRID ) CONST
D Error LIKE ( DFN_ERRMG )

D wUserId S LIKE ( DFN_USRID )
D STATIC

IF wUsrId<> UserId;
CHAIN UserId USRCFD;
If not %found;
error = ....
RETURN *OFF;

ENDIF;

RETURN *ON;

P SetUserInfo B

--
This is the RPG programming on the IBM i / System i
(RPG400-L) mailing list To post a message email:
RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change
list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.