Re: trying to be modular

["Lennon_s_j@xxxxxxxxxxx" <lennon_s_j@xxxxxxxxxxx>]

From what I see, there is vast sharing of global data going on. (Paul's 
comment on coupling is on the mark.) Personally, I dislike sharing 
global data.  I'd much rather see this in a service program.

However, from reading other posts you have made, I suspect that there is 
resistance in your shop to, shall we say, more modern approaches to 
program design.  So, you may have done the best you can under the 
circumstances.

Sam

On 12/8/2010 8:51 AM, David FOXWELL wrote:
> This is an attempt at modularising my code. At the risk of getting slammed, I ask if it is acceptable and to tell me what the disadvantages may be and how I should have done this.
>
> Had to get an authorization level from a user information table to condition a screen indicator in an existing program. The user table contains lots of other information like name, department and telephone number, etc.
>
> In my pgm :
>
> // *IN49 is already on.
>
> IF GetAutLevel>= '4';
>     *IN49 = *OFF;
>
> ENDIF;
>
> 	
> In a separate module where the user table is already used, I added :	
>
> 	
>   P GetAutLevel     B                   EXPORT
>   D                 PI                  LIKE ( DFN_AUTLV )
>   D UserId                              LIKE ( DFN_USRID ) CONST
>   D Error                               LIKE ( DFN_ERRMG )
>
>   D wAutLv          S                   LIKE ( DFN_AUTLV )
>
>         IF NOT SetUserInfo ( UserId : Error );
>            RETURN *BLANK;
>
>         ENDIF;
>
>         RETURN UAUTNV; // From user table
>
>   P GetAutLevel     E
>
>
>
>
>   P SetUserInfo     B
>   D                 PI              N
>   D UserId                              LIKE ( DFN_USRID ) CONST
>   D Error                               LIKE ( DFN_ERRMG )
>
>   D wUserId         S                   LIKE ( DFN_USRID )
>   D                                     STATIC
>
>      IF wUsrId<>  UserId;
>         CHAIN UserId USRCFD;
>          If not %found;
>             error = ....
>             RETURN *OFF;
>
>          ENDIF;
>
>       RETURN *ON;
>
>   P SetUserInfo     B