Re: Constants in RPG - what would you do?

[Booth Martin <booth@xxxxxxxxxxxx>]

Explain it.  Be sure to use your 5 choices so he understands there is an 
issue, and what the issue is. 

What I have done in the past is to send an e-mail and then immediately 
walk over and say to the boss "I just sent you an e-mail."    That gets 
me past my tendency to hem and haw, lets him see what I want to say, and 
gives him a chance to think about it before he responds.  It also 
documents the issue in case it ever comes up again.

The e-mail you just sent to the list is a great one to send (except the 
part about writing stuff down for the boss).   



David FOXWELL wrote:
> Ok, a programmer just added a procedure to a new module I'm working on ( not the same programmer who wrote the above code).
>
> In it, he coded
>
>
> D gCRP_DNN         C            'A'
>
> As it's my program, what's worse is it's signed by me!
>
>
> I didn't think it possible but maybe it's even worse than the example above.
>
> Now what would you do in my situation, given that the boss has asked you to make note of this kind of thing?
>
> 1. Change the constant as it's part of your program, to something more understandable. Actually I've no idea what it means.
> 2. Tell the person who wrote it to change it : embarassing, as that person is my senior.
> 3. Tell the boss.
> 4. Comment the constant so that the next programmer won't blame you for it.
> 5. Do nothing.
>