× The internal search function is temporarily non-functional. The current search engine is no longer viable and we are researching alternatives.
As a stop gap measure, we are using Google's custom search engine service.
If you know of an easy to use, open source, search engine ... please contact support@midrange.com.



6. Ask the person who wrote it what CRP_DNN stands for. Discuss the
fact that you wouldn't have had to ask if it had a more meaningful
name. Get him to agree that it should be changed. Then change it.

Charles


On Thu, Apr 16, 2009 at 8:55 AM, David FOXWELL <David.FOXWELL@xxxxxxxxx> wrote:
 -----Message d'origine-----
 De : rpg400-l-bounces@xxxxxxxxxxxx De la part de Charles Wilt

 *   Type relation = aunt
D gA          C            'A'

 myRelation = gA;


That's just plain silly.

Of course it is. Any advice on how to break the news to the
person who
wrote it?



Ok, a programmer just added a procedure to a new module I'm working on ( not the same programmer who wrote the above code).

In it, he coded


D gCRP_DNN         C            'A'

As it's my program, what's worse is it's signed by me!


I didn't think it possible but maybe it's even worse than the example above.

Now what would you do in my situation, given that the boss has asked you to make note of this kind of thing?

1. Change the constant as it's part of your program, to something more understandable. Actually I've no idea what it means.
2. Tell the person who wrote it to change it : embarassing, as that person is my senior.
3. Tell the boss.
4. Comment the constant so that the next programmer won't blame you for it.
5. Do nothing.
--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.



As an Amazon Associate we earn from qualifying purchases.

This thread ...

Replies:

Follow On AppleNews
Return to Archive home page | Return to MIDRANGE.COM home page

This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].

Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.