Re: Constants in RPG - what would you do?

-----Message d'origine-----
De : rpg400-l-bounces@xxxxxxxxxxxx De la part de Charles Wilt

* Type relation = aunt
D gA C 'A'

myRelation = gA;

That's just plain silly.
Of course it is. Any advice on how to break the news to the

person who

wrote it?

Ok, a programmer just added a procedure to a new module I'm working on ( not the same programmer who wrote the above code).

In it, he coded


D gCRP_DNN C 'A'

As it's my program, what's worse is it's signed by me!


I didn't think it possible but maybe it's even worse than the example above.

Now what would you do in my situation, given that the boss has asked you to make note of this kind of thing?

1. Change the constant as it's part of your program, to something more understandable. Actually I've no idea what it means.
2. Tell the person who wrote it to change it : embarassing, as that person is my senior.
3. Tell the boss.
4. Comment the constant so that the next programmer won't blame you for it.
5. Do nothing.