RE: Exiting a sub procedure

As far as I can see the only advantage you have with the AND-alternative
suggested by me is that there are less lines. If I remember correctly I
made a remark that this alternative is for the not-faint-of-hearted (or
words of the same meaning). It might keep the almighty (or at least that
is what they think of themselves) source-code-reviewers with
C-background out of your hair but farther than that I would not really
see any advantages. As you rightfully state, it makes maintenance that
much harder, and CPU power costs less than man-hours in maintenance.

The EXSR example which does the return is just hiding the fact that
there are still multiple RETURN-points and for me personally is not
acceptable for that fact alone. There should be one RETURN point
(equally as there should be only one SETON *LR, *INLR = *ON point) in
any program. If you want to express the fact which check failed there
are many possibilities (throwing exceptions, sending messages, writing
logs/files/records/dataqueue entries whatever) which allow you to do so
and the exact implementation thereof heavily depends on whatever is
normal in the situation.

Cor

-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-
bounces@xxxxxxxxxxxx] On Behalf Of Rory Hewitt
Sent: woensdag 26 november 2008 0:44
To: RPG programming on the AS400 / iSeries
Subject: Re: Exiting a sub procedure

See, unlike you guys, my code often doesn't work, meaning I need to
spend
lots of time debugging it, hence my dislike of in-line function
calls...

Seriously though, I looked at all the various suggestions for making
all the
calls in-line and shuddered. Are there *any* benefits to having a
single
multiple-AND statement over separate statements? I guess it maybe

looks

cooler, but it's almost certainly no faster and much harder to debug
and
maintain.

On Tue, Nov 25, 2008 at 3:34 PM, Vern Hamberg <vhamberg@xxxxxxxxxxx>
wrote:

LOL Adam!!

Just trying to be ornery! I do use functions in-line myself - and
sometimes wish I hadn't!

Vern

--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing
list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.