RE: Adoption of new RPG techniques

Aaron,

yours?


    DOMParser =
         DOMParser_init(
         pSourceType: pSourceString: pValidate: 37: pErrorProcPtr);
    DOMDoc = DOMParser_getDocument(DOMParser);

    root = DOMDoc_getRootElem(gDOMDoc);
    XPathSeparator = '/';
    // Get Batch information
    batch.id = #CtoN(DOMXPath_getAttrValue(root: 'Batch/id': *Omit));
    batch.customerDivision =
      #CtoN(DOMXPath_getAttrValue(root: 'Batch/customerDivision':*Omit));
    batch.customerSubDivision =
      #CtoN(DOMXPath_getAttrValue(root: 'Batch/customerSubDivision':
*Omit));
    batch.customerId =
      #CtoN(DOMXPath_getAttrValue(root: 'Batch/customerId': *Omit));

 or mine?

c                   eval      DOMParser =
c                                 DOMParser_init(
c                                        pSourceType:
c                                        pSourceString:
c                                        pValidate:
c                                        37:
c                                        pErrorProcPtr)
c                   eval      DOMDoc = DOMParser_getDocument(DOMParser)
c                   eval      root = DOMDoc_getRootElem(gDOMDoc)
c                   eval      XPathSeparator = '/'

c* // Get Batch information

c                   eval      batch.id =
c                               #CtoN(DOMXPath_getAttrValue(
c                                          root:
c                                         'Batch/id':
c                                          *Omit))

c                   eval      batch.customerDivision =
c                               #CtoN(DOMXPath_getAttrValue(
c                                          root:
c                                         'Batch/customerDivision':
c                                          *Omit))

c                   eval      batch.customerSubDivision =
c                               #CtoN(DOMXPath_getAttrValue(
c                                          root:
c                                         'Batch/customerSubDivision':
c                                          *Omit))

c                   eval      batch.customerId =
c                               #CtoN(DOMXPath_getAttrValue(
c                                          root:
c                                         'Batch/customerId':
c                                          *Omit))
I fail to see how your 'real world stuff' is any easier to read than mine.
In fact, separating the parms to separate lines actually cleans it up,
don't you think?

would you like to try again?

rick