RE: Strange behavior w/%editc()

["McCallion, Martin" <martin.mccallion@xxxxxxxxx>]

Joe Pluta wrote:

> In any event, if, in your mind
>
>     eval %subst(lotnumber : 3 : 8) = %editc(Lotseq : 'X')
>
> is a logical replacement for
>
>     MOVE LOTSEQ LOTNUMBER
>
> then fine.  I disagree.  I think the extra coding is
> unnecessary.

To quote McConnell (_Code Complete_): "explicit is better than
implicit".  In the former statement it's very clear that the intent is
to modify a substring of the lotnumber; in the latter it is not.

>  Not only
> that, but to keep the exact equivalence (that is, the code
> will still put
> the lot sequence in the last six positions of the lot number,
> regardless of
> the size of my lotnumber field), I have to do this:
>
>     eval %subst(lotnumber : (%len(lotnumber) - %len(lotseq)) + 1 :
> %len(lotseq)) =
>          %editc(lotseq : 'X')

This is certainly messier, but careful formatting and liberal use of
whitespace can vastly improve readability.  For example:
        eval %subst( lotnumber :
                     ( %len( lotnumber ) - %len( lotseq ) ) + 1 :
                     %len( lotseq ) ) =
             %editc( lotseq : 'X' )

That doesn't look too great in a proportional font, but in fixed-width
it should be fine.

Cheers,

Martin.

--
Martin McCallion
Senior Technical Consultant
Work:  martin.mccallion@misys.com
Home: martin.mccallion@ukonline.co.uk
Misys International Banking Systems
1 St George's Road, London, SW19 4DR, UK
T +44 (0)20 8486 1951
F +44 (0) 20 8947 3373
www.misys.com
This email message is intended for the named recipient only. It may be
privileged and/or confidential. If you are not the  intended named
recipient of this email then you should not  copy it or use it for any
purpose, nor disclose its contents to any other person. You should
contact Misys International Banking Systems as shown below so that we
can take appropriate action at no cost to yourself.
Misys International Banking Systems Ltd,1 St
George's Road, London, SW19 4DR, UK. Email: ibs.postmaster@misys.com.
Tel: +44 (0) 20 8879 1188 Fax: +44 (0) 20 8947 3373
Misys International Banking Systems Ltd is
registered in England and Wales under company no. 971479