Re: Comparing Collections

Thorbjorn,
I do return the value in the second version I posted. It was an error in the
code. In my original code I had:

if (c1.size() > c2.size()) {
return 1;
}

if (c1.size() < c2.size() {
return -1;
}

But I thought that since the contract only requires the value to be a
positive or negative, then the simple subtraction would do.

So it should be:
int c = c1.size() - c2.size();
if (c != 0)
return c;

Just forgot the most important 2 lines of code. I appreciate you pointing
that out though. Sill mistake, but could have consequences if it was left
incorrect.

I have actually no heard of Test Driven Design before. I will have to read
about it a bit more, but my normal testing procedure seems to follow the
basics I read about it. My first goal is to make sure it runs, then see if I
can break it :-)

As always, thanks for the input!

--
James R. Perkins
http://twitter.com/the_jamezp


On Wed, Sep 2, 2009 at 23:11, Thorbjoern Ravn Andersen <ravn@xxxxxxxxxx>wrote:

James Perkins skrev:

/**
* Compares the first collection against the second collection.

Returns

a
* negative integer, zero or positive integer.
* <p>
* If the size of the first collection is greater than the size of

the

* second collection, a positive integer is return. If the size of

the

first
* collection is less than the size of the second collection a

negative

* number is returned.
* </p>

int c = c1.size() - c2.size();

The javadoc does not conform to the code :) You do not return a value
if the size is unequal.

Have you considered using Test Driven Design to write such a library? I
usually do this because it works well for me focussing on a given
detail, while the tests catch if I mess something up.

--
Thorbjørn Ravn Andersen "...plus... Tubular Bells!"

--
This is the Java Programming on and around the iSeries / AS400 (JAVA400-L)
mailing list
To post a message email: JAVA400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/java400-l
or email: JAVA400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/java400-l.