Done!
Created PMR# 22937,442,000 Refactor-rename multiple lines does not work in RDI 9.5.1.2
-Ken Killian-
-----Original Message-----
From: Ken Killian
Sent: Tuesday, August 8, 2017 11:06 AM
To: Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries <wdsci-l@xxxxxxxxxxxx>
Subject: RE: [WDSCI-L] RDI 9.5.1.2 Refactor-Rename Problem, does not work on Multiple lines...
Edmund,
Yes, re-wording is fine! No problems.
I will open an PMR, which generates an APAR, I assume. At least I consistently reproduce this issue...
Thanks!
-Ken Killian-
-----Original Message-----
From: WDSCI-L [mailto:wdsci-l-bounces@xxxxxxxxxxxx] On Behalf Of Edmund Reinhardt
Sent: Tuesday, August 8, 2017 10:52 AM
To: Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries <wdsci-l@xxxxxxxxxxxx>
Subject: Re: [WDSCI-L] RDI 9.5.1.2 Refactor-Rename Problem, does not work on Multiple lines...
Hi Ken,
The RFE is great and I like having all of your votes to help boost its priority.
But what you are describing here, seems to be a straight bug.
Upon further investigation (Barbara Morris beat me to it :-)
The rename in the problem description wouldn't necessarily cause the final line to exceed the source length. The line ends at column 63. Clicking on Refactor gives an error immediately, without giving the option to give a new name.
It seems to be an issue with a name followed by a left-parenthesis where the right-parenthesis is on a later line. For the following code, trying to rename "abc" gets the error, but trying to rename "def" is fine.
XML_Input = abc ( OldOrd : NewOrd) // Renaming abc works fine
;
XML_Input = def ( OldOrd // Renaming def fails right away
: NewOrd);
(Nothing to do with **FREE; it's the same in column-limited code.)
So this is clearly a bug.
Feel free to open an APAR. In the mean time, I will open a defect and get to it as soon as I can as I don't want the next release to go out with this in it.
Are you OK with me rewording the RFE to be more general, it will help it move forward?
Edmund
From: Ken Killian <kkillian@xxxxxxxxxxxx>
To: "Rational Developer for IBM i / Websphere Development Studio
Client for System i & iSeries" <wdsci-l@xxxxxxxxxxxx>
Date: 2017-08-02 04:03 PM
Subject: Re: [WDSCI-L] RDI 9.5.1.2 Refactor-Rename Problem, does not
work on Multiple lines...
Sent by: "WDSCI-L" <wdsci-l-bounces@xxxxxxxxxxxx>
Edmund,
Thanks so much for all the improvement on RDI! It has been GREAT! Like refactor-rename!
Yes, it was **free format. My source is 262, to force me to use a modern tool set like RDI.
Our production source is 112. So I check for code going past column-100, before promoting.
So, I was looking to rename: "Create_XML_Input" to "Create_Order_Merge_XML_Input".
Because it goes through a "Order-Merge" process, more descriptive for the next developer.
The normal global replace with the WHOLE-WORD works great in LPEX, just have to be extra carefully, in case it goes out of scope. Which is why the Refactor-Rename is so AWESOME! Takes some of the worry and double-checking out!
Yes, it would be NICE, but not a "MUST-HAVE" feature. I just expected it to work, since it was a valid "*free" Statement.
Maybe I am the only one who runs into this small thing.
I only brought this up, because RDI is supposed to be 100% compatible with **free format.
I start my coding in column-01! <Big Smile> I do NOT need any punch card limitation!!!!! Never used a punch-card-machine for writing code, that was before my time.
This was coded inside of a procedure, with all the code in column-01. No logic statements in this particular procedure.
My new formatted code: it does NOT past column 70! <grin> //
00000011111111112222222222333333333344444444445555555555666666666677777777778888888888999999999900000000000
//
45678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890
XML_Input = Create_Order_Merge_XML_Input( OldOrd // C016
: NewOrd // C016
: OldRteParts // C016
: NewRteParts // C016
) // C016 ; // C016
Yup, they still require us to mark code with "Change-Markers"... <LOL>
PS. This was a SQLRPGLE service program, if that makes a difference in how the parser is interpreted.
I will input an RFE for this tomorrow...
-Ken Killian-
-----Original Message-----
From: WDSCI-L [mailto:wdsci-l-bounces@xxxxxxxxxxxx] On Behalf Of Edmund Reinhardt
Sent: Wednesday, August 2, 2017 11:59 AM
To: Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries <wdsci-l@xxxxxxxxxxxx>
Subject: Re: [WDSCI-L] RDI 9.5.1.2 Refactor-Rename Problem, does not work on Multiple lines...
Hi Ken,
At this point we can rename anything that doesn't cause the line after the rename to be longer than will fit in your SRC-PF.
We don't have the functionality yet, to reflow the line, which would also imply formatting preferences etc.
We certainly would entertain an RFE requesting this.
I am a little curious why this rename failed. You current line is 50 characters. If this is not fully free form, it was probably indented by at least 8 characters. How long was your new procedure name and what is the record length of your source-pf?
I would have expected this to fit for a reasonable length procedure name.
HTH
Edmund
From: Ken Killian <kkillian@xxxxxxxxxxxx>
To: "Rational Developer for IBM i / Websphere Development Studio
Client for System i & iSeries" <wdsci-l@xxxxxxxxxxxx>
Date: 2017-07-10 10:07 AM
Subject: [WDSCI-L] RDI 9.5.1.2 Refactor-Rename Problem, does not
work on
Multiple lines...
Sent by: "WDSCI-L" <wdsci-l-bounces@xxxxxxxxxxxx>
Hi,
I am using RDI 9.5.1.2 and tried to use refactor rename, and I got this
Error:
Renaming across line boundaries is not supported. Cannot rename "Create_xml_input" on line 1874: "XML_Input = Create_XML_Input( OldOrd".
Here is my code:
XML_Input = Create_XML_Input( OldOrd // Line 1874
: NewOrd
: OldRteParts
: NewRteParts
)
;
So, I assume that refactor does not support code that goes across multiple Lines?
Oh yeah, the refactor took a LONG TIME... I guess it wanted to rebuild the outline first or something. Took well over 1-minutes. I guess in this case a scan & replace is better and faster... <LOL>
I was trying to give my procedure a more meaningful name.
Should I even bother to open a PMR on this? Maybe this requires a RFE? Not sure.
-Ken Killian-
--
This is the Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries (WDSCI-L) mailing list To post a message
email: WDSCI-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/wdsci-l
or email: WDSCI-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/wdsci-l.
--
This is the Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries (WDSCI-L) mailing list To post a message
email: WDSCI-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/wdsci-l
or email: WDSCI-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/wdsci-l.
--
This is the Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries (WDSCI-L) mailing list To post a message email: WDSCI-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/wdsci-l
or email: WDSCI-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/wdsci-l.
--
This is the Rational Developer for IBM i / Websphere Development Studio Client for System i & iSeries (WDSCI-L) mailing list To post a message email: WDSCI-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/wdsci-l
or email: WDSCI-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/wdsci-l.
midrange.com
