Re: RPG Refactoring - removing GOTO - tips & techniques?

I don't disagree...

But unless you happen to have 100% automated testing...

It's a lot easier to get approval for small refactorings, whose "diff" is
easily understood to have not changed the logic...rather than a complete
rewrite...

Especially when the app is "moving off the i" anyway...

Charles

On Fri, Oct 13, 2017 at 1:21 PM, Booth Martin <booth@xxxxxxxxxxxx> wrote:

I've hesitated to join this thread. One point I have not seen expressed,
and may well be pushing the edges of the scope of the topic is this:

Programs with Goto's tend to be programs designed for business as it was
in the 1980s and earlier. Business rules change, worker base kills change,
and solutions change. It is my experience that these old programs worry
about 5-digit zip codes, fax numbers, y2k concerns, and users who don't
know how to use a mouse or a scroll bar. Many of these 1000-line programs,
with today's %bifs and SQL, etc, are easily reduced to 125-line & less.

My point is that cobbling together all that old code with new words takes
longer than cracking the old program open and exposing it the 21st century.
Lets take off the corsets, wigs, lace collars, and high-button shoes.

The concern I often here is "We don't want to overlook a business rule."
That concern was erased for me when I encountered the following business
rule: "any employee who washed the boss's car during the depression is
granted a 5 cent pay raise for the rest of his working life." Granted,
that wasn't recent, but it was real.

On 10/13/2017 10:26 AM, Charles Wilt wrote:

On Thu, Oct 12, 2017 at 3:20 PM, John Yeung <gallium.arsenide@xxxxxxxxx>
wrote:

Ah, but it could be!

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD