Re: how to remove this 'GOTO'

On Jan 25, 2016, at 4:58 PM, dr2@xxxxxxxx wrote:


Jon,

Point conceded, HOWEVER, anyone that just wants to modify legacy code for
some purist academic endeavor is asking for a huge can of worms to be
opened....and that even presumes they have the latest and correct source
code.

I don't have any problems with goto-less programming, etc... My concern
is that just because you can, doesn't mean you really should....also known
as if it ain't broke, don't fix it! :) :)

DR2

There is another option Don.

Perhaps he wants to get away from columnar RPG and move to /Free. That
requires the well-deserved death of the GOTO.

On Jan 25, 2016, at 4:03 PM, dr2@xxxxxxxx wrote:

Let me see if I understand this right.

Is this a logic error or are you wanting to be a purist and remove a
"goto" just for the sake of not having a "goto" in your legacy code?

If it's a logic error, then that's one thing. If you're just wanting to
remove a "goto" from legacy code for the sake of some misplaced purist
coding concepts that someone may have taught you in school, then I would
suggest you're definately not only going down the wrong path but running
the risk of creating problems for yourself and wasting alot of
time/money...unless of course you're billable by the hour and have
successfully talked your naive client into thinking this needs to be
changed in all their code...

Frankly, I'd say if the code works correctly with the "goto" in place,
LEAVE IT THERE AND GO FRY BIGGER FISH!

DR2

HI Problem I have is that apprently, Royalty info is stored in 2 files.
The program was only looking at one file. The first set of code that
gets
Royalty amt. was commented out. I uncommented because I saw that this
file
does have Royalty amt. So, I am thinking to run the first code and if
it
finds an amt. skip the second. Because the second was not finding
before
and the report was showing zero.

I do not want to have a goto please can you inform me how to do this
code
without the goto?
The reason being, I dont' want to touch what is currently working.

*** Get Royalties for receipt (first)
C eval KeyLcType = ROY
C RecKey Chain SrbOrplc
C If %Found(SrbOrplc)
C eval PpRoyal = OcAmou
c goto writer
C EndIf
*** Get Royalties for receipt (**Second)
C If GrSpno > 0
C eval KeyLcType = ROY
C RecKey2 Chain Sr2Lca
C If %Found(Sr2Lca)
C eval PpRoyal = CaAmou
C Else
C eval PpRoyal = 0
C EndIf
C EndIf
c writer TAG
C Write GrtOutF
--
This is the RPG programming on the IBM i (AS/400 and iSeries)
(RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Jon Paris

www.partner400.com
www.SystemiDeveloper.com

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.