Yes we do.
The best thing that have worked for us is to put a experienced programmer that knows both the system (functionality and code) to review by comparing the old and the new versions of changed programs. Only those programs/changes from the approved projects are promoted to production.
We have prevented both minor and major situations when the programmer has not followed specs properly, or not followed standards.
That is time consuming, but at the end has been valuable for the amount of time that one should invest with customer support or fixing emergency issues.
jmerinoh
-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of RNewton@xxxxxxxxxxxxxxxxx
Sent: Tuesday, November 15, 2011 2:13 PM
To: RPG programming on the IBM i / System i
Subject: Re: Do you do formal code reviews?
I take it no one here does code reviews in their shop?
Robert Newton
Estes IT
System Architect
804-353-1900 x2256
rnewton@xxxxxxxxxxxxxxxxx
From:
RNewton@xxxxxxxxxxxxxxxxx
To:
RPG programming on the IBM i / System i <rpg400-l@xxxxxxxxxxxx>
Date:
11/11/2011 08:55 AM
Subject:
Do you do formal code reviews?
Sent by:
rpg400-l-bounces@xxxxxxxxxxxx
How does your shop implement code reviews for ensuring quality and enforcing coding standards?
Do you have software to manage the process and what are the metrics that you collect?
Thanks,
Robert Newton
Estes IT
System Architect
804-353-1900 x2256
rnewton@xxxxxxxxxxxxxxxxx
For 80 Years ? Delivering Solutions that Exceed Expectations.
This communication and any transmitted documents are intended to be confidential. If there is a problem with this transmission, please contact
the sender. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or
copying of this communication is strictly prohibited.
--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/rpg400-l.
For 80 Years ? Delivering Solutions that Exceed Expectations.
This communication and any transmitted documents are intended to be confidential. If there is a problem with this transmission, please contact the sender. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited.
--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit:
http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at
http://archive.midrange.com/rpg400-l.
midrange.com
