Re: Data Structure Overlay & *next

[Rory Hewitt <rory.hewitt@xxxxxxxxx>]

Kurt,

One quick point: You don't need to name the filler fields 'Filler'. It may
be preferable to you (or a coding standard that you use), but I tend to find
it's actually nicer to just leave the field names blank (and also leave the
type blank too), e.g.:

    D dsT_Ani         DS                  Qualified Template
    D   Npa                          3s 0
    D   Nxx                          3s 0
    D                                6

    D dsT_Zip         DS                  Qualified Template
    D   Zip4                         9a
    D                                3

I find this differentiates these filler fields a little (they 'pop' out at
me) when I'm looking at the code - especially the lack of field type makes
it clear that the data in them can't be 'trusted' to be alpha. Plus it may
avoid name clashes...

Just personal preference, obviously :)

Rory

On Tue, Apr 19, 2011 at 11:50 AM, Kurt Anderson <
kurt.anderson@xxxxxxxxxxxxxx> wrote:

> Hi Charles,
>
> Late reply I know, but I appreciate your feedback. I like your idea about
> doing the subfield thing.  Especially since the section of code I presented
> is repeated 3 times.  I like that it looks a bit cleaner as well:
>
>     D dsT_Geo         DS                  Qualified Template
>     D   State                        2s 0
>     D   County                       3s 0
>     D   City                         4s 0
>     D   Sub                          3s 0
>
>     D dsT_Ani         DS                  Qualified Template
>     D   Npa                          3s 0
>     D   Nxx                          3s 0
>     D   Filler                       6a
>
>     D dsT_Zip         DS                  Qualified Template
>     D   Zip4                         9a
>     D   Filler                       3a
>
>     D ds_example      DS                  Qualified
>     D  Orig                         12a
>     D   ds_OrigGeo                        Overlay( Orig: 1 ) LikeDS(
> dsT_Geo )
>     D   ds_OrigAni                        Overlay( Orig: 1 ) LikeDS(
> dsT_Ani )
>     D   ds_OrigZip                        Overlay( Orig: 1 ) LikeDS(
> dsT_Zip )
>     D  Term                         12a
>     D   ds_TermGeo                        Overlay( Term: 1 ) LikeDS(
> dsT_Geo )
>     D   ds_TermAni                        Overlay( Term: 1 ) LikeDS(
> dsT_Ani )
>     D   ds_TermZip                        Overlay( Term: 1 ) LikeDS(
> dsT_Zip )
>
>
> Thanks!
>
> Kurt