Re: Does the recommendation against variable names starting with SQL apply to constants?

David,

Bad idea IMHO, you should have either taken the time to change all
references or used the existing but poorly named one.

Having two names for the same thing makes things more confusing for
the next guy, not less. You've went from one WTF to two WTFs.

WDSCi makes it easy to see every line with a X0, IIRC so does SEU. It
shouldn't have been hard to change them.

If you're doing proper regression testing, it shouldn't matter if you
changed one line or fifty.

Even if you're not doing good regression testing, if you can't change
the name of a constant and feel good about your changes you're
probably in the wrong line of work.

Charles

On Fri, Sep 3, 2010 at 10:06 AM, David FOXWELL <David.FOXWELL@xxxxxxxxx> wrote:

-----Message d'origine-----
De : rpg400-l-bounces@xxxxxxxxxxxx
[mailto:rpg400-l-bounces@xxxxxxxxxxxx] De la part de Charles Wilt

Though instead of adding my own long name, I would have spent
the extra time and replaced the short name with a longer one.

I thought about that, and that's what my first instinct was but as I think Dennis was implying, if it ain't broke...
Had I done as you say, I would have risked my own behind for wasting time as some would see it.

So, I didn't touch the code that "weren't broke". Future programmers will be now be able to choose between a constant with my new meaningful name and cXO.
--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.