Re: Does the recommendation against variable names starting with SQL apply to constants?

Not sure if I should be flattered or concerned that I've got a follower! :)

In any case, you're right I wouldn't like SUCCESSFUL_SQL_STATE.

Not a big fan of STATE_SQL_SUCCESSFUL either for that matter, it just
doesn't read right to me:
if sqlState = STATE_SQL_SUCCESSFUL;

readability of the code is a big one for me.

I think the SQL_STATE needs to be there, simply to avoid namespace clashes.

The only thing that reads right to me is SQL_STATE_SUCCESSFUL, so if I
were to change it I suppose I'd go with Birgitta's suggestion of
cSQL_STATE_SUCCESSFUL as it's pretty easy to ignore the 'c'.

I suppose another thought would be QSQL_STATE_SUCCESSFUL or maybe
QSQLSTATE_SUCCESSFUL. I like those since they given an indication
that the values are "owned" by IBM. In fact, my copy member is
actually names QSQLSTATES. But are there any recommendations against
starting a variable or constant with 'Q'? I know you're not supposed
to create objects on the system that start with 'Q'.

But I'm leaning towards Scott's example of not trying to fix it before
it actually breaks something. :)

Charles


On Wed, Sep 1, 2010 at 4:09 AM, David FOXWELL <David.FOXWELL@xxxxxxxxx> wrote:

-----Message d'origine-----
[mailto:rpg400-l-bounces@xxxxxxxxxxxx] De la part de Schutte,
Michael D.

You know what they say about assuming? You could just change
the naming.

SUCCESSFUL_SQL_STATE
NO_DATA_SQL_STATE
NO_MORE_RS_SQL_STATE

I've been a follower of Charles' naming techniques for a while now. I don't think he'd like those names.

Maybe :
STATE_SQL_SUCCESSFUL
STATE_SQL_NO_DATA
STATE_SQL_NO_MORE_RS

would be more his style. Although I'm not sure why SQL and STATE need to be included in the constant names.

Presumably, they would be used like : if SQLSTATE = SQL_STATE_SUCCESS

Why not

RS_NOT_FOUND
RS_FOUND
RS_END_OF_FILE

etc.








--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.