Re: ILE newbie question....

On 27/10/2007, at 6:45 AM, Emily Smith wrote:

ROLE is a field in cmsuserf. The chain is successful, and I can verify that the record that is found has data in the field ROLE. However, in debug, if I display the value of ROLE it shows as blanks both before and after the chain, and ROLE is passed back to CMSADD as blanks. Maybe this is an easy answer, but right now I'm stumped.

ROLE is a field in the file therefore must have GLOBAL scope (at least in current releases).

role is a variable in the procedure and therefore has LOCAL scope.

Locally scoped variables obscure globally scoped variables of the same name.

Thus the use of role as an I/O parameter on the cmssecure() procedure is obscuring and changing the value of ROLE from a successful chain.

Also, since this is my first attempt, any other critique or comment is definitely welcomed and appreciated.

I wouldn't write this the way you have. I would make role a return value from the procedure. This will both fix the original problem AND make the code cleaner. Without rewriting your code entirely (which I would do in production code) here is an example:

D*----------------------------------------------------------------
D* Procedure Prototype
D*----------------------------------------------------------------
D cmssecure pr 1a opdesc
D username 10a
D
D CMSadd pr opdesc
D username 10a
P cmsadd b export
D pi opdesc
D username 10a
*
*Verify security
*

C EVAL role = cmssecure(username)

CMSSECURE:
D CMSSECURE pr 1a opdesc
D username 10a
*
P cmssecure b export
D pi 1a opdesc
D username 10a
*
C Username chain rcmsuserf
C if Not %found
C return 'X'
C else
C return ROLE
C endif
P cmssecure e



Regards,
Simon Coulter.
--------------------------------------------------------------------
FlyByNight Software OS/400, i5/OS Technical Specialists

http://www.flybynight.com.au/
Phone: +61 2 6657 8251 Mobile: +61 0411 091 400 /"\
Fax: +61 2 6657 8251 \ /
X
ASCII Ribbon campaign against HTML E-Mail / \
--------------------------------------------------------------------