Re: Quick question on readability

I would prefer the more readable (familiar) method but I would use
select in case I needed to add additional conditions where I should turn
on the indicator.  ( sure you could add this to your if statement but
you remove the readability of the code when the if gets complex) 


Thanks,
Tommy Holden


-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx
[mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of Alan Shore
Sent: Thursday, December 14, 2006 9:10 AM
To: RPG programming on the AS400 / iSeries
Subject: **SPAM** Re: Quick question on readability

When I first read this e-mail, I had a flashback.
As an ex-mainframe COBOLer of multiple decades,(now an RPG'er for 1
decade)
this code took me back to my UNIVAC 1108 days where there was an
extension
by UNIVAC to COBOL
var1 = (var2 = value)
which meant change BOTH var1 AND var2 to value
var1 and var2 being fields (NOT indicators)
and for the reason of someone else maybe following and making changes to
the RPG program I will ALWAYS use
if var1 = var2;
  namedIndicator = *on;
else;
  namedIndicator = *off;
endif;

over :-

namedIndicator = (var1 = var2);



Alan Shore

NBTY, Inc
(631) 244-2000 ext. 5019
AShore@xxxxxxxx

rpg400-l-bounces@xxxxxxxxxxxx wrote on 12/13/2006 12:31:34 PM:

Do people like or dislike this type of code:

/free
  var1 = (var2 = value);

  namedIndicator = (var1 = var2);

/end-free

Thanks in advance for any opinions,
Adam

########################################################################
#############

Attention:
The above message and/or attachment(s) is private and confidential
and is intended
only for the people for which it is addressed. If you are not named
in the address
fields, ignore the contents and delete all the material. Thank you.
Have a nice day.

For more information on email virus scanning, security and content
management, please contact administrator@xxxxxxxxxxxx

########################################################################
#############

--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing

list

To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.