Re: halt with readdir

[Scott Klement <rpg400-l@xxxxxxxxxxxxxxxx>]

> C* Open directory
> C                   eval      returnDir = opendir(%addr(FullName))

This code is incorrect.  You shouldn't be specifying %addr() here.  Change 
this to %trim(FullName).



> C* Terminate if error occurred when opening directory
> C                   if        ReturnDir = *Null
> C                   eval      *inlr = *on
> C                   return
> C                   endif

Here you're not doing proper error handling.  You should be retrieving an 
error message if opening the directory fails -- not simply ending the 
program and telling the user nothing!


> C                   dou       PtrToEntry = *null
> C* Read next directory entry
> C                   eval      PtrToEntry = readdir(ReturnDir)
> C* error?
> C                   if        PtrToEntry = *null
> c                   callp     EscErrno(errno)
> c                   endif

Here you ARE doing error handling, but there's still a problem!  readdir() 
returns *NULL when it hits the end of the directory, so your program will 
crash with an *ESCAPE message, in spite of the fact that nothing is wrong.

readdir() returns *NULL, but doesn't change errno, when it hits the end of 
a directory.

readdir() returns *NULL and does change errno when an error occurs.


> C* Determine object type of entry
> C                   eval      EntryPath = %trim(DirName) + '/'
> C                             + %trimr(EntryName) + Null
> C                   eval      ReturnInt = lstat(%addr(EntryPath)
> C                                            : %addr(StatDS))

Again, you should not be using %addr() here for the EntryPath.  The only 
reason you'd use %addr() is if you needed your code to be compatible with 
V3R2 which was the ONLY release of ILE RPG where you needed to use 
%addr().

Your prototype should have options(*string), and instead of using %addr() 
and manually adding a null to the end, you should simply be passing a 
trimmed variable.