Re: read on a do loop

On Mon, 2005-08-22 at 10:07 -0400, Paul Morgan wrote:
> Rich,
> 
> This is just my coding style but I'd take the Not out of the read subroutine
> and put it up in the calling DoW statement:
> 
> DoW Not ReadExample();
> EndDo;
> 
> To Me it's less confusing if the ReadExample just returned the %Eof
> indicator.  Using an *Off indicator for 'no more records' isn't the way RPG
> programmers are used to coding read loops.
> 
> Paul

Interesting.  I think a function should return true on success.  How
about instead:

dow read_example() = SUCCESS;
enddo;

And then you can define the constant SUCCESS to be whichever way you
like it to be?  

Also, keep in mind that the read_example function as written is
incomplete.  It currently returns NOT %eof, but does not handle any type
of read error.


Regards,
Rich