Re: SQL Query Returns and Runaway Errors -- RPG400-L


On 16/06/2005, at 11:11 PM, Brian Piotrowski wrote:

I'm having two problems with it:

1) The error checking works, but when an error occurs, the program goes

into an endless loop and locks up. The only way I can stop it is toend

the session or cancel the program.

2) My SQL statement is written successfully, but no data is returned.
Again, it appears to go into an endless loop.

If anyone has any ideas, I'd really appreciate it.  Thanks, and here's
the code for your review:

This program is so poorly structured I'm not surprised it's behavingbadly. Parts of it are alright but the do-everything FindKL subroutineis a bit of a mess. And a lot of the stuff in *INZSR doesn't seem tobelong there either. Ask yourself these questions:


For problem 1:

When an error occurs how is the error displayed to the user? How willthey be able to respond to the error?


For problem 2:

When records are written to the subfile how is it displayed to theuser? How will they be able to specify another search?

The root cause is the same in both cases. You never display the screento the user. The subfile control record is written only in *INZSR andSFLClear. The prompt is only written during *INZSR. After that younever display the results. Even though you write the error message younever read the screen which would stop your endless loop. Even when youpopulate the subfile you never display the control record which is whythe data doesn't appear. Nor do you read from the control record whichwould also stop your endless loop.


Also,

         If rrn = 0;
sfldsp = *ON; <==== THIS IS WRONG BUT NOT THE CAUSEOF THE PROBLEM.
          else;
            lastrrn = rrn;
          endif;




Regards,
Simon Coulter.
--------------------------------------------------------------------
   FlyByNight Software         AS/400 Technical Specialists

   http://www.flybynight.com.au/
   Phone: +61 3 9419 0175   Mobile: +61 0411 091 400        /"\
   Fax:   +61 3 9419 0175                                   \ /
                                                             X
                 ASCII Ribbon campaign against HTML E-Mail  / \
--------------------------------------------------------------------