|
Marvin; Effiecient how? You are actually testing for %Eof twice for each execution of the loop, except for the first and last, and IMO the test for %Eof should only occur in one place. John; If the chain fails on the first execution you will still execute the code within the DoW, because %Eof does not return the success or failure of the Chain operation, only %Found does. For readability, maintainability, and the reasons expressed above, my suggestion would be: C myklist setll myfile C myklist reade myfile C dow NOT %eof(myfile) C eval rrn = rrn + 1 C write mysubfile C myklist reade myfile C enddo Duane -----Original Message----- From: John Brandt Sr. [mailto:pgmr@xxxxxxxxxxxxxxx] Sent: Friday, March 26, 2004 10:12 AM To: 'RPG programming on the AS400 / iSeries' Subject: RE: RPG400-L Digest, Vol 3, Issue 231 While his code would write a duplicate record at the bottom of the subfile, and your code may be efficient, my suggestion would be: C myklist chain myfile C dow NOT %eof(myfile) C eval rrn = rrn + 1 C write mysubfile C myklist reade myfile C enddo JMHO John Brandt iStudio400.com -----Original Message----- From: Marvin Radding [mailto:MRadding@xxxxxxxxxxxx] Sent: Friday, March 26, 2004 9:58 AM To: rpg400-l@xxxxxxxxxxxx Subject: RE: RPG400-L Digest, Vol 3, Issue 231 While there is nothing wrong with your code, I think this way is more effiecient. C myklist setll myfile C C dou %eof(myfile) C C myklist reade myfile C if %eof(myfile) C iter C endif C C eval rrn = rrn + 1 C write mysubfile C C enddo Marvin Radding message: 1 date: Thu, 25 Mar 2004 14:32:35 -0800 (PST) from: simafrog <SimaFrog@xxxxxxxxxx> subject: SETLL ONE SLIGHT PROBLEM Actually I don't think I can do this here anyway. One problem remaining is that the reade of the Detail file is causing one extra record to be added to the work file, the last one of the batch is duplicated. Here is the code: C BLD BEGSR C* C OHKEY SETLLORDHEDR 40 C* C *IN40 DOWEQ*OFF C* C OHKEY READEORDHEDR 40 C *IN40 IFEQ '0' C* C C* C ODKEY SETLLORDDTL 50 C *IN50 DOUEQ*ON C ODKEY READEORDDTL 50 C WRITEORDSWRKF C END C END C END C* C ENDSR _______________________________________________ This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options, visit: http://lists.midrange.com/mailman/listinfo/rpg400-l or email: RPG400-L-request@xxxxxxxxxxxx Before posting, please take a moment to review the archives at http://archive.midrange.com/rpg400-l. --- Incoming mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.642 / Virus Database: 410 - Release Date: 3/24/04 --- Outgoing mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.639 / Virus Database: 408 - Release Date: 3/22/04 _______________________________________________ This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options, visit: http://lists.midrange.com/mailman/listinfo/rpg400-l or email: RPG400-L-request@xxxxxxxxxxxx Before posting, please take a moment to review the archives at http://archive.midrange.com/rpg400-l. NOTICE: This electronic mail transmission may contain confidential information and is intended only for the person(s) named. Any use, copying or disclosure by any other person is strictly prohibited. If you have received this transmission in error, please notify the sender via e-mail.
As an Amazon Associate we earn from qualifying purchases.
This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].
Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.
midrange.com
