RE: memory and pointers and variable length fields

[Chris Bipes <chris.bipes@xxxxxxxxxxxxxxx>]

Patrick,

I would declare constants for the ASCII control characters.
i.e. 
d cNewLine c x'OD'
d cCR      c x'25'

Then substitute them for the hex values in your calc specs.  Also since you
have defined pointer for the data structure, inz them in the D specs and
forget about the evals.
d p_InBuff s inz(%addr(SocketData))

I would also eval the OutBytes to be equal to the InBytes instead of using
the %Len twice.  You only need to use one pointer variable.  Since p_InBuff
= p_OutBuff = SockDtaPtr = %addr(SocketData), I would only use one pointer,
d p_SocketData s inz(%addr(SocketData)) and put that in place of the
p_InBuff, p_OutBuff and SockdatPtr.  At lease try to use the same variable
naming convention for all your constants, pointer...
All our constants start with a lower case "c" and all pointer are "p_".

None of which will help improve the way the program behaves but make it more
readable and maintainable for the next guy.

Good Job,


Christopher K. Bipes    mailto:ChrisB@Cross-Check.com
Sr. Programmer/Analyst  mailto:Chris_Bipes@Yahoo.com
CrossCheck, Inc.        http://www.cross-check.com
6119 State Farm Drive   Phone: 707 586-0551 x 1102
Rohnert Park CA  94928  Fax: 707 586-1884

If consistency is the hobgoblin of little minds, only geniuses work here.
Karen Herbelin - Readers Digest 3/2000

-----Original Message-----
From: Patrick Conner [mailto:pwconner@charter.net]
Sent: Thursday, March 22, 2001 8:10 AM
To: rpg400-L@midrange.com
Subject: memory and pointers and variable length fields

+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---