Re: File field names

I am sure that failure to use the prefix would be caught given adequate
testing.

I've seen files that are prefixed in the DDS have the same field names.
Think about it.  Of the dozens of files in an ERP system which may use
ITEM#.  There is a good chance it could happen.  You need to have
standards.  And that standard should include the use of the PREFIX keyword
where appropriate.

I've also seen fields added to a file that no longer use the same prefix.
For example:
BPCS-BBL file
BLCUST
BLSHIP
BLDOCR
LUDTE1
LUDTE2
BLCUSB
Again, canned software from a different vendor.

And I am sure that your opinion that large prefixes, like qualified names,
making programs unreadable may be held in disagreement from many quarters.
Some people forget that BL means the BBL or Billing release line items
file.  But that problem would happen if you used PREFIX or your method of
manual prefixing.

But if you choose not to prefix, then you have the capability to move data
from one file to another without z-adds, moves or evals.  Mostly useful for
migrations.

Rob Berendt

==================
Remember the Cole!


                                                                                
                                          
                    Jim Langston                                                
                                          
                    <jimlangston@conexfr        To:     RPG400-L@midrange.com   
                                          
                    eight.com>                  cc:                             
                                          
                    Sent by:                    Subject:     Re: File field 
names                                         
                    owner-rpg400-l@midra                                        
                                          
                    nge.com                                                     
                                          
                                                                                
                                          
                                                                                
                                          
                    10/26/00 11:11 AM                                           
                                          
                    Please respond to                                           
                                          
                    RPG400-L                                                    
                                          
                                                                                
                                          
                                                                                
                                          




In our system, which is a S/36 legacy system, every field in a file starts
with the same 2 initial characters.  CMFile fields all start with CM,
EqpMst
fields all start with EQ, etc...

This was the way it was in the S/36 program, so was extended to the DDS for
the then flat files.  This is something I had done in one of my own systems
in another language (dBase & Clipper) to distinguish fields.

I had gotten into trouble in dBase from naming my fields the same name,
which
I had thought would be a good thing.  Fields such as TaxPct, which was not
a
normalized field because of tax rate changes, were the same in all files.
Then
one day there was a very strange bug in my program and I traced it down
that
I was doing something like InvAmt = TaxPct * Total.  Tracking further I
found
that it was using the wrong TaxPct value, that it should of been using it
from
the Invoice Header, but instead it was pulling it from the Customer Header
(default tax rate) and they were different for some reason.

I then started doing something like InvAmt = InvHead->TaxPct * Total and
found
I was missing it in a lot of places and it made my code very unreadable.
Then I went through every single one of my files and every single program
and put in 3 characters in front of each field, IH_TAXPCT for invoice
header,
CS_TAXPCT for Customer, etc..  Then I didn't have any more problems.  This
is,
I think, the best way to go, as it prevents accidental misuses of
variables.

Yes, you can use Prefix in your files, until the one time you only have one
file
in your program so don't need it.  Then later someone goes back and needs
to add
another file (user wants us to validate tax rate now so we chain to tax
file) and
they don't realize, or remember, or think about using the prefix, since the
other
file doesn't have it, now suddenly we are back using the wrong field.

Even worst, I think they might be both the same field.  If we have the same
field
name in 2 different files of the same type wouldn't RPG just store them in
the same
memory location?  Ouch.

Regards,

Jim Langston

Just my $0.04 worth (inflation and all)



rob@dekko.com wrote:
>
> That's your problem, right there.  You're adding a prefix when you code a
> PF.  For example, if you called the item number ITEMNUM in both ITEMMAST
> and ORDDET then a simple query against the file QSYS/QADBIFLD would show
> you everywhere the field is used.  If you want to use the two files in
the
> same program then you simply do a PREFIX on the F spec in RPGIV.  There
are
> commercial canned software applications out there which do this.  They
> actually work and make sense.  People can adapt.
>
> Adopting this technique makes referencing obsolete.  Except maybe in
screen
> or printer files.
>
> Rob Berendt
+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator:
david@midrange.com
+---



+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---