RPG IV program - comments requested

[bmorris@xxxxxxxxxx]

>From:    Jim Langston [mailto:jlangston@conexfreight.com]
>Sent:    Friday, September 24, 1999 11:39 AM
>
>I would request critiquing of this program.  That is, I am using D specs to
>declare my variables, I am using a PLIST to declare my entry parameters

Jim, I would replace the *ENTRY PLIST with a prototype and procedure interface.
When you call your program from ILE RPG, copy the prototype into the calling
module and use CALLP to call it.  Lots of advantages to doing this; one
advantage is that you can get used to using prototyped calls before you have to
mess with creating modules and other ILE stuff.

/Copy file:
  |D PGMNAME         PR                    EXTPGM('PGMNAME')
  |D  Trailer                      10      CONST
  |D  SCACCode                      4A     CONST

Program source D specs:
    /COPY prototype
    * Entry parameters
   D PGMNAME         PI
   D  Trailer                      10       CONST
   D  SCACCode                      4A      CONST

(Code CONST on the parms since they aren't changed by your code.  This allows
callers to CALLP with literals instead of declaring fields to hold the trailer
and SCAC code.)

In D specs, I always leave a space between the "D" and the name, and indent
things like parameters and subfields, to show the relationship between the D
specs.

Barbara Morris


+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---