Re: RPG IV program - comments requested

[Gary Guthrie <GaryGuthrie@xxxxxxxx>]

Here are a few comments with my personal opinion. 

1) Rather than using *ENTRY PLIST, move the parameter definitions to the
D-specs with the rest of the data definitions. You can do this using a
procedure prototype with the ExtPgm keyword. The value you specify for
the ExtPgm keyword is the name of the program itself. For instance, if
your program is called UPDSHIP, use UPDSHIP as the value for ExtPgm.

2) Use mixed case everywhere in your program. It's easier to read. (I
couldn't tell from your field names where upper and lower case is
appropriate, but you get the point)

3) Try to align Eval statements on the = (or >, etc.)

Here is a reworked copy of your program with the changes made. Your
original program appears at the end of this message.

      FBSShipX   UP   E             Disk

      D EntryParms      PR                  ExtPgm('TEST')    
      D  Trailer                      10                      
      D  SCACCode                     10                      
      D EntryParms      PI                                    
      D  Trailer                      10                      
      D  SCACCode                     10                      
 
      C                   If        Trailer = BSXtrl
      C                   Eval      BSSCAC  = SCACCode
      C                   Update    BSShipX1
      C                   EndIf
 
Note that I supplied the name EntryParms in the procedure prototype.
This can be anything, but EntryParms makes things a bit more intuitive.
 
Gary Guthrie
Editor, The RPG Source at http://www.news400.com/TheRPGSource



(Your original program)


      FBSSHIPX   UP   E             DISK
 
      DTrailer          S             10A
      DSCACCode         S              4A
 
      C                   IF        Trailer = BSXTRL
      C                   EVAL      BSSCAC = SCACCode
      C                   UPDATE    BSSHIPX1
      C                   ENDIF
 
       *******************************
       *** Set up Entry Parameters ***
       *******************************
      C     *INZSR        BEGSR
      C
      C     *ENTRY        PLIST
      C                   PARM                    Trailer
      C                   PARM                    SCACCode
      C
      C                   ENDSR
+---
| This is the RPG/400 Mailing List!
| To submit a new message, send your mail to RPG400-L@midrange.com.
| To subscribe to this list send email to RPG400-L-SUB@midrange.com.
| To unsubscribe from this list send email to RPG400-L-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---