Re: standards for coding constants

Sounds like RPG. Might want to move this to the RPG list.

I suspect they named their constants as a combination of 1970's style 6
character field name underline possible value for it. They might have
done this to document why they have this constant defined in their
copybook. It was their choice to do this versus a readable constant and
actually adding comments in their code like:
// Constants for possible values for customer types. Often used to
compare
// against the customer type in such-and-such file.
d gCustomer_Type_Teacher c 'TEA'
...

Then there's another train of thought. Why are your customer types
constants instead of in their own table? Infor has their Customer Type
file (RCT). Among it's columns are:
Record ID
Company Number
Customer Type
Currency Code
Type Description
A/R Account Number
Cash Account
Foreign Posting Company
Foreign Posting Profit Center
Realized Gain Account
Realized Loss Account
Unrealized Gain Account
Unrealized Loss Account
Realized Gain Profit Center
Realized Loss Profit Center
Unrealized Gain Profit Cntr
Unrealized Loss Profit Cntr
Bill Back Accrual Account
Bill Back Accrual Profit Ctr
A/R Control Acct Profit Center

Maybe you could look at the select or if statements you are using and see
if it can be table driven.



Rob Berendt