Re: standards for coding constants

I believe it's the later. if the variable was already name wCstTy what
good does naming the constant CSTTY?
It's the same unreadable code.
The whole point of using constants is writing long explanations. For
example when you make a mask in bitwise operations...
byte = EnableDST + NoPPW + EnableUltraMode + NoSystemShutdown etc etc
etc. Meaning you can read without referencing the copybook.
The copybook should only be needed to WRITE the constant, not to read it.

Best Regards,


On Tue, Apr 24, 2012 at 9:54 AM, Jeff Crosby <jlcrosby@xxxxxxxxxxxxxxxx> wrote:

I'm not sure I understand what you're complaining about.

You asked for a copybook of constants, you got it, and now you're
complaining because you have to use it?  Or are you complaining because the
constant was named " gCSTTY_TEA" instead of " gCUSTOMER_TYPE_TEACHER?"



On Tue, Apr 24, 2012 at 8:43 AM, Dave <dfx1@xxxxxxxxxxxxxx> wrote:

Here’s an example of our shop’s  RPG code :



IF wCstTy = ‘TEA’ ;



Means if the customer type indicates a teacher. Cst for customer, Ty for
type, w for local variable.



I would write this way, using a globally defined constant :



IF wCstTy = gCUSTOMER_TYPE_TEACHER ;



I proposed that we create a copybook for such constants so that everyone
would use the same names and to avoid seeing this kind of thing :



D gA                 C          CONST(‘A’)



My wish was granted, and a copybook has been created. But now, I can’t use
the constant in my example above. I now have to write :



IF wCstTy = gCSTTY_TEA ;



I feel like I’m bashing my head against a brick wall.



Any comments to make me see the error of my ways would be more than
welcome.
--
This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing list
To post a message email: MIDRANGE-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/midrange-l
or email: MIDRANGE-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/midrange-l.

--
Jeff Crosby
VP Information Systems
UniPro FoodService/Dilgard
P.O. Box 13369
Ft. Wayne, IN 46868-3369
260-422-7531
www.dilgardfoods.com

The opinions expressed are my own and not necessarily the opinion of my
company.  Unless I say so.
--
This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing list
To post a message email: MIDRANGE-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/midrange-l
or email: MIDRANGE-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/midrange-l.