Re: Code review?

We do code review. We have another programmer go thru the code to make sure coding and naming standards are followed. We look for in souce documentation as well.

As a programmer, the first thing to remember is that even with standards, not everyone codes the same. We are to look at the code for functionality and not based on how we would do the coding. I look at this process as a way to learn from others.

We call our process Test In Programming or TIP testing.

As programmers, we need to remember we are professional but we are human. We make mistakes. The review process is not about pointing out those mistakes. It is about not letting those mistakes get to the end-user.

Nick Mart

----- Original Message ----- From: "Steve McKay" <steve.mckay@xxxxxxxxxxx>
Newsgroups: midrange.midrange-l
To: <midrange-l@xxxxxxxxxxxx>
Sent: Wednesday, April 08, 2009 8:38 AM
Subject: Code review?

Is anyone doing code review on new or modified code before moving it to production? If so, what is your process? Who participates in the code review? How ticked off do the programmers get when someone doesn't like their code? Pros? Cons?

It seems to me that you would have to have shop standards and review the code versus the shop standard rather than having everyone in the review tell how 'they' would've coded the program.

All opinions welcomed.

Thanks,

Steve


--
This is the Midrange Systems Technical Discussion (MIDRANGE-L) mailing list
To post a message email: MIDRANGE-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/midrange-l
or email: MIDRANGE-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/midrange-l.