On Mon, 7 Feb 2005, Ruel, Marc-Antoine wrote:
I have one warning, please don't put the Tn5250Win and following variables global since I will hardly be able to use your code otherwise.
I just compared session.c. I think that your version is probably better but I, as I written in the comments, took the tn5250j project as reference since this one did work correctly on the page I had to make work. I am not a 5250 user so I just fixed the reported error users gave me. :)
Why did you change the type of border_length to unsigned char? Does it have to wrap around 255? It does add a lot of burden to the code.
This could probably be made an int.
I agree with you it would be better to remove the FCW and FFW values and use variables with significant name. Why do you discard the continuous flags (first, middle, last) and just set your flag to 1? In fact we could use one variable instead of the 3 continued_XXX with an enum (or define).
It's not the software that's free; it's you. - billyskank on Groklaw
As an Amazon Associate we earn from qualifying purchases.
Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.