> d) There are extra/unnecessary blank pixels between each line of text on
>    the screen.  Compare an xterm screen with the same font to an x5250

Here's a patch that works for me that solves the problem with having too
many empty pixels between each line. Please try it, and consider it for
the next x5250 release.

diff -u ../../orig/x5250-0.4.6/src/x5250.c ./x5250.c
--- ../../orig/x5250-0.4.6/src/x5250.c  Wed Dec  1 20:24:16 2004
+++ ./x5250.c   Sun Dec  5 20:13:05 2004
@@ -1013,7 +1013,7 @@
     }
   else
     {
-      columnsepheight = font_height;
+      columnsepheight = font_height - 2;
     }


@@ -1066,73 +1066,73 @@
                      XDrawLine (display, win, terminal->data->gcgreen,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_WHITE:
                      XDrawLine (display, win, terminal->data->gcwhite,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_RED:
                      XDrawLine (display, win, terminal->data->gcred,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_BLUE:
                      XDrawLine (display, win, terminal->data->gcblue,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_YELLOW:
                      XDrawLine (display, win, terminal->data->gcyellow,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_TURQUOISE:
                      XDrawLine (display, win, terminal->data->gcturquoise,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_PINK:
                      XDrawLine (display, win, terminal->data->gcpink,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    case A_X5250_BLACK:
                      XDrawLine (display, win, terminal->data->gcblack,
                                 (widthbuf * underlinestart),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE,
+                                BASELINESPACE + 2,
                                 (widthbuf * j),
                                 ((font_height + ROWSPACING) * (i + 1)) +
-                                BASELINESPACE);
+                                BASELINESPACE + 2);
                      break;
                    }
                  underlineactive = 0;
diff -u ../../orig/x5250-0.4.6/src/x5250.h ./x5250.h
--- ../../orig/x5250-0.4.6/src/x5250.h  Tue Oct 26 13:16:04 2004
+++ ./x5250.h   Sun Dec  5 20:13:14 2004
@@ -62,7 +62,7 @@


 /* Amount of space (in pixels) to place between rows on the screen */
-#define ROWSPACING 4
+#define ROWSPACING 1

 /* Amount of space (in pixels) to place below the font baseline and
  * the field underline

As an Amazon Associate we earn from qualifying purchases.

This thread ...

Replies:

Follow On AppleNews
Return to Archive home page | Return to MIDRANGE.COM home page

This mailing list archive is Copyright 1997-2022 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].

Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.