tn5250 bug frustration

[Scott Klement <klemscot@xxxxxxxxxxxx>]

Hi,

I've been complaining about a bug since the 0.13.x series of tn5250.  The
bug happens (at least, this is where I see it) when you do this:

1) Type UPDDTA SOMELIB/SOMEFILE on the AS/400
2) Hit F10 & Enter  immediately (as fast as you can) 

In March, just after version 0.15.8 was released, Mike Madore was kind
enough to look into this bug, and fix the problem.   That really made my
life easier, since I was not accidentally crashing tn5250 all the time.

Unfortunately, Mike's fix caused system request to stop working when the
keyboard was locked.  Which, silly me, I also asked to have fixed.  Then,
Jay Felice went and removed Mike's fix....  unknowingly causing my UPDDTA
bug to resurface.

Now, another release is made!  Now?  After removing the bug fix that I
yearned and lusted after for so long? Frustrating.

I posted a message on May 26th, saying this:

------------------------start of quoted message----------------------------

> I fixed the usage message in CVS, and I'm backing out the pending_aid
> stuff. If it causes any bugs, I'll fix 'em. 

Yep, it causes bugs.   It reintroduces the "hit enter too fast in DFU
causes a assertion failed" error that Mr. Madore fixed at my request 
in March.

(Thats the same error that I had been complaining about for a year or so)

changing it to (below), however, solves the problem:

void tn5250_display_do_aidkey (Tn5250Display *This, int aidcode)
{
   TN5250_LOG (("tn5250_display_do_aidkey (0x%02X) called.\n", aidcode));

   /* FIXME: If this returns zero, we need to stop processing. */
   if ((This->session->read_opcode)||(aidcode==TN5250_SESSION_AID_SYSREQ))  
        ( *(This->session->handle_aidkey)) (This->session, aidcode);
}

------------------------end of quoted message----------------------------

The line that I added was the "if" line.  With this taken care of, the
system request works (error reset as well, tho that never didnt work since
its handled internally, anyway) 

Now, I'm sure that this isnt the best way to fix the problem.  But if 
nobody is going to take the time to fix it correctly, can you please at
least put _MY_ fix in for the time being?

I know I'm a pest about this stuff -- but hey, I just want the thing to
work, just as you do... :)

+---
| This is the LINUX5250 Mailing List!
| To submit a new message, send your mail to LINUX5250@midrange.com.
| To subscribe to this list send email to LINUX5250-SUB@midrange.com.
| To unsubscribe from this list send email to LINUX5250-UNSUB@midrange.com.
| Questions should be directed to the list owner/operator: david@midrange.com
+---