[WEB400] Re: QtmhRdStin and QzhbCgiParse Limitation

[Hans Boldt <boldt@xxxxxxxxxx>]

Bartell, Aaron L. (TC) wrote:

> Ok, whew, this is a marathon thread. <wiping brow>
>
> Here is the latest version with User Space processing included, and it works
> just fine.  Now, am I to assume that I am not over writing any memory that
> doesn't belong to me?
>
> (http://mowyourlawn.com/temp/CGI_readToFile.txt)
>
>
> Aaron Bartell

Now that looks better! Just a few comments, but these are more along 
the lines of cleanup:

1) For the ON-ERROR clauses, identify specifically the exceptions 
you're looking for. That way, unexpected errors don't fall through. 
(You can always add a catch-all ON-ERROR at the end of the MONITOR 
group to catch the genuinely unexpected exceptions.)

2) For the second MONITOR group, since you're specifically watching 
for a failure of "qtmhRdStin", just that call should be wrapped in 
the MONITOR group. (Note that an exception on creating the user 
space will also yield the message "Error reading Standard Input".)

3) On the subject of checking the success of the call to 
"qtmhRdStin", shouldn't you be checking "ErrorDs"?

4) All of the 9B0 variables should really be 10I0. (There's really 
no good reason any more for using binary decimal variables.)

5) Hmmm, I know this is unlikely, but after the "qtmhRdStin", what 
if "bytesRead" does not have the same value as "contentLength"?

Cheers! Hans