RE: Free format question on D specs

[Roger Harman <roger.harman@xxxxxxxxxxx>]

*ON/*OFF just harken back to indicators.  The less I see or think of indicators, the happier I am.  True/False can be consistent across languages.  You'll never see *ON/*OFF outside of RPG.

As to meaningful Boolean names... absolutely.  But, consider a standard.  I lean towards err<Something>  or flg<Something>.


Roger Harman
COMMON Certified Application Developer – ILE RPG on IBM i on Power



.

-----Original Message-----
From: RPG400-L [mailto:rpg400-l-bounces@xxxxxxxxxxxxxxxxxx] On Behalf Of Booth Martin
Sent: Thursday, January 24, 2019 9:54 PM
To: RPG programming on the IBM i (AS/400 and iSeries)
Subject: Re: Free format question on D specs

Stylistically I have wondered why we ever use Yes/No'; we already have 
the very clear *on & *off.

Why not a meaningful named indicator for each condition being tested?  
Something like ItIsReady, WeMayCall, or just Flag1, Flag2,etc.

giving us code like:

     if ItIsReady;
       SendInvoice();
       ItIsReady = *off;
     endif;


On 1/24/2019 10:54 PM, Joe Pluta wrote:
> Thomas, others have addressed the syntactical part of your question, 
> but I have a stylistic suggestion.  Rather than using variables x_yes 
> and x_no, I prefer to use constants:
>
> dcl-c C_YES 'Y';
> dcl-c C_NO 'N';
>
> My own preference is to uppercase literals and precede them with C_; 
> that makes it very clear when I use a literal.  Then I can write the 
> following:
>
> if xzstas <> C_YES and xsstas <> C_NO;