× The internal search function is temporarily non-functional. The current search engine is no longer viable and we are researching alternatives.
As a stop gap measure, we are using Google's custom search engine service.
If you know of an easy to use, open source, search engine ... please contact support@midrange.com.



Not a question just of "safety" Mark - but in this case the _correct_ way. Passing a varchar when char is expected is wrong no matter what unless Const is used to correct the situation but that is a performance issue.


Jon Paris

www.partner400.com
www.SystemiDeveloper.com

On Mar 30, 2018, at 12:12 PM, mlazarus <mlazarus@xxxxxxxxxxxx> wrote:

Charles,

As Dan mentioned, he's interested in the concept of what's going on, not the specific API interface requirement. But you and Jon are correct about the safer way to do it, in this case.

-mark

On 3/30/2018 11:26 AM, Charles Wilt wrote:
Jon's correct...

Qc3CalculateHash() takes a char(*) as the first parm, you can't change the
prototype to varchar and get the right results.

You need to change DataToHash to char.

Or you could leave it varchar and use this proto

dcl-pr hash extproc('Qc3CalculateHash');
InputData pointer value;
LengthOfInputData int( 10);
//did you realize you're missing a lot more parms?
end-pr;

hash(%addr(DataToHash:*DATA):%len(DataToHash);

Charles


On Thu, Mar 29, 2018 at 11:28 PM, Dan<dan27649@xxxxxxxxx> wrote:


Thanks Mark!

I changed the first parm in the prototype to varchar and now it works like
a charm.

On the inputlen statement, I simply got rid of the %trim altogether, since
DateToHash is varchar.

- Dan


On Fri, Mar 30, 2018 at 12:56 AM, mlazarus<mlazarus@xxxxxxxxxxxx> wrote:


Dan,

You're passing a varying character field to a fixed length parm, as
defined in the prototype. Options(*varsize) allows you to pass

differently

sized variables of the same type, in this case it would be a fixed length
field, without the compiler complaining. An easy fix would be to add

Const

to the prototype. Then the compiler would adjust it for you. Or make

the

parm in the prototype varying (varchar).

Just a note on the other part of the code. This statement:

inputlen = %len(%trim( DataToHash));

gets the length of the fully trimmed variable, yet you're passing an
untrimmed version:

hash( DataToHash: inputlen );

So if you have leading blanks you'll get the hash based on a value with
leading blanks, but ignoring the trailing characters, for the number of
leading blanks. You're probably looking for %TrimR() instead of %Trim().

-mark


--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

Help support midrange.com by shopping at amazon.com with our affiliate
link: http://amzn.to/2dEadiD


--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: https://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at https://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

Help support midrange.com by shopping at amazon.com with our affiliate link: http://amzn.to/2dEadiD


As an Amazon Associate we earn from qualifying purchases.

This thread ...

Follow-Ups:
Replies:

Follow On AppleNews
Return to Archive home page | Return to MIDRANGE.COM home page

This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].

Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.