RE: READ for not exact key -- RPG400-L

Never understood why old code is left in anyway. At least not past the testing/debug stage.

Does it serve a purpose other than to say... "somebody changed their mind."?

It's not very good as documentation and as you say, it's more difficult to read when dealing in older SEU style editors or B&W prints.

Duane

-----Original Message-----
From: RPG400-L [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of John R. Smith, Jr.
Sent: Wednesday, March 09, 2016 11:19 AM
To: 'RPG programming on the IBM i (AS/400 and iSeries)' <rpg400-l@xxxxxxxxxxxx>
Subject: RE: READ for not exact key

"My personal opinion, I HATE when other programmers only put an * on the line to comment it out. There should be more than one or at least move the rest of the line so that it no longer lines up with the rest of the code.
I always end up reading that as being active code."

I personally hate the misalignment / jaggedness (in non-free of course) so I have started putting ** right in front of the opcode as in **ENDDO (along with the required * in the comment column). This keeps alignment correct but is VERY obvious that the line is commented out. I also do the same with CL and DDS.

-----Original Message-----
From: RPG400-L [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of Michael Schutte
Sent: Tuesday, March 8, 2016 4:48 PM
To: RPG programming on the IBM i (AS/400 and iSeries)
Subject: Re: READ for not exact key

Okay. that's what we were missing. pol is a key list. The more information the better. We cannot only guess when you don't provide enough information.

Your program should be reading equal to prod and ohorno value. Since
lline is an "*" right after the "c", that line is commented out and isn't being used in the SETLL or READE.

But I see that in another email you gave the code to step2. In step2 you have another read on another file. That read is changing the %EoF and causing your DOU to end prematurely. In your EoF function put the file name that you are wanting to check.

My personal opinion, I HATE when other programmers only put an * on the line to comment it out. There should be more than one or at least move the rest of the line so that it no longer lines up with the rest of the code.
I always end up reading that as being active code.

On Tue, Mar 8, 2016 at 3:56 PM, Hoteltravelfundotcom < hoteltravelfun@xxxxxxxxx> wrote:

What I want to do is process all the order# lines.
I am getting the order# from previous step. From header.

Now here I want to read all order lines. But its doing only 1 time.

pol setll srbpol
if %equal
dou %eof
pol reade srbpol
ohords iflt 30
eval ohsrom = svsrom
eval ohsrom = whs
eval oloqty = svqty
eval olline = svline
update orppl
*now take this line item and qty and update warehouse balances
eval item = olprdc
exsr step2
endif
enddo
endif
*

pol
( I remove the orderline from ths klist because I wont be getting that
from the previous read which is the order header)

c pol klist
c* Production order:Ord no: Ord line:
c kfld prod
c kfld ohorno 1200
c* kfld lline 500

On Tue, Mar 8, 2016 at 3:53 PM, Roche, Bob <broche@xxxxxxxxxxxxxxxxx>
wrote:

I will say first I am in the SETLL READ DOW group.
From what I remember SETLL does not set %EOF. %EOF Without a file
designator uses last file read, in this case we don't have enough
code to know the file it is referencing. So the DOU %EOF has no
reference on the first pass. This coding made more sense with
indicators because you can

set

the indicator before entering your loop. You cannot in the program
set

%EOF.

Of course if I'm wrong about SETLL and %EOF this email was a waste.

-----Original Message-----
From: RPG400-L [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of
Hoteltravelfundotcom
Sent: Tuesday, March 08, 2016 2:00 PM
To: RPG programming on the IBM i / System i <rpg400-l@xxxxxxxxxxxx>
Subject: READ for not exact key

pol setll srbpol
if %equal
dou %eof
pol reade srbpol
ohords iflt 30
eval ohsrom = svsrom

Pol = order#

actual key of file is

order#
orderline

when running I am only getting one read. Is that correct?

the thing is, I dont have order lines from the previous file read
that header where I get the order#/.

Do I create my own order line values? or should this be working.
--
This is the RPG programming on the IBM i (AS/400 and iSeries)
(RPG400-L) mailing list To post a message email:
RPG400-L@xxxxxxxxxxxx To

subscribe,

unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx Before posting, please take
a moment to review the archives at
http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.
--
This is the RPG programming on the IBM i (AS/400 and iSeries)
(RPG400-L) mailing list To post a message email:
RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list
options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx Before posting, please take
a moment to review the archives at
http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

--
This is the RPG programming on the IBM i (AS/400 and iSeries)
(RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx Before posting, please take a
moment to review the archives at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related
questions.

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L) mailing list To post a message email: RPG400-L@xxxxxxxxxxxx To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives at http://archive.midrange.com/rpg400-l.

Please contact support@xxxxxxxxxxxx for any subscription related questions.

________________________________
________________________________
CONFIDENTIALITY NOTICE: This electronic message transmission is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. If you have received this transmission, but are not the intended recipient, you are hereby notified that any disclosure, copying, distribution or use of the contents of this information is strictly prohibited. If you have received this e-mail in error, please contact NALC Health Benefit Plan at 703-729-4677 and delete and destroy the original message and all copies.