Re: Service programs, procedures, not sure what to do

Brad,

My code was sort of an equivalent of how you would do it in Java:

MailData maildata = new MailData();
maildata.setValue('fromAddress':'jclarkson@xxxxxxxxxxx');
(or maildata.setFromAddress('jclarkson@xxxxxxxxxxx');)
maildata.send();

The reason I do it that way is that in my scenario the caller owns the
memory. In your scenario the service program owns the memory. In practice
it probably won't make much of a difference, but I think the caller should
be the owner of the memory. And in my scenario it would be possible to
have more than one MailData 'object', in your scenario it is a singleton.

Joep Beckeringh

Bradley Stone <bvstone@xxxxxxxxx>

08-01-2015 14:14

Subject:

Re: Service programs, procedures, not sure what to do

I apologize, I see you're using "MailData" as a sort of data structure.
For my applications that's inside the service program/module itself. No
need to pass it along or have it in the application.

That is similar to how I did things years ago with GETURI (and hope to
update), but different.

Brad
www.bvstools.com

On Thu, Jan 8, 2015 at 7:09 AM, Bradley Stone <bvstone@xxxxxxxxx> wrote:

Joep,

That's exactly how I do it. I think the only difference is your reset
action, which I actually use as a proc itself. (in reality, I have an
init() and reset() procedures that do similar things, such as setting
values to defaults, etc).

My description wasn't 100% complete, but hopefully enough to get the

point

across. I find it MUCH easier than passing a bunch of parameters,

which as

we know can and will change over time.

Brad
www.bvstools.com

On Thu, Jan 8, 2015 at 3:43 AM,

<j.beckeringh@xxxxxxxxxxxxxxxxxxxxxxxxxx>

wrote:

Brad,

If you use setters that way, where are the values stored? If these
subprocedures reside in a service program, you use the service

program as

a sort of singleton object. I would prefer something like this:

reset MailData;
setValue(MailData :'fromAddress':'jclarkson@xxxxxxxxxxx')
setValue(MailData :'toAddress':'rhammond@xxxxxxxxxxx')
setValue(MailData :'subject':'Come drive the new Ariel Atom')
setValue(MailData :'message':message)
sendEmail(MailData);

It's almost like Java :-) (And I don't even like Java!)

Joep Beckeringh

From:

Bradley Stone <bvstone@xxxxxxxxx>

06-01-2015 23:13

Subject:

Re: Service programs, procedures, not sure what to do

One thing I've been doing lately for subprocedures instead of

passing a

lot

of parameters (which can change over time) is using "setters"

before

calling the real subprocedure.

An example is the ILE subprocedures I did for our MAILTOOL

application.

Instead of sendEmail(fromAddr:toAddr:subject:message:......)

I use "setters" to set the value of values that can be used by the
subprocedure. The first parm in the setter is the value to set,

the

second

is the actual value which is set up as a global field in the

module/service

program.

Inside the setValue() subprocedure is really just a large select

statement

that sets the values as they are passed in.

setValue('fromAddress':'jclarkson@xxxxxxxxxxx')
setValue('toAddress':'rhammond@xxxxxxxxxxx')
setValue('subject':'Come drive the new Ariel Atom')
setValue('message':message)
sendEmail();

This is a very high level explanation of how I do it, but so far

it's

working quite splendidly.

Just something to think about if you're just starting out with
subprocedures.

ps.. I also prefix them according to their use, so these would all

be

mailtool_setValue, mailtool_sendEmail, etc...

Just an idea while you take your exciting journey down the ILE

road. :)

Brad
www.bvstools.com

--
This is the RPG programming on the IBM i (AS/400 and iSeries)

(RPG400-L)

mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

--
This is the RPG programming on the IBM i (AS/400 and iSeries)
(RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

--
This is the RPG programming on the IBM i (AS/400 and iSeries) (RPG400-L)
mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.