data structure question -- RPG400-L

What happens when you compile this? Does it even compile? You have two endif's, and only one if that I found. You also have an else without a matching if. and I am not even real sure what error condition you are expecting to trap with that %error() statement since the preceding source is an assignment.

There is a lot missing here since you are doing array processing, but have nothing defined that is an array (nothing that you showed us anyway).

What is the error you are getting?

Mark Murphy
STAR BASE Consulting, Inc.
mmurphy@xxxxxxxxxxxxxxx

-----rpg400-l-bounces@xxxxxxxxxxxx wrote: -----
To: RPG programming on the IBM i / System i <rpg400-l@xxxxxxxxxxxx>
From: Amanda Paul
Sent by: rpg400-l-bounces@xxxxxxxxxxxx
Date: 06/25/2012 11:44AM
Subject: data structure question



Hello
Assuming that p_dsCmpabc,p_dsCmpdef,p_dsCmpghi,p_dsCmpklm,p_dsCmpnop,p_dsCmpqrs and p_dsCmpuvw are empty DS passed in the below call, If the procedure call is successful I want to see that all these datastructures get populated, could you please let me know if I am missing any thing?

Is the error handling procedure need to be repeated for each data structure so each one gets populated if there is no error?

populateGeneralRisks(client:branch:product:Company:p_dsCmpabc:p_dsCmpdef:p_dsCmpghi:p_dsCmpklm:p_dsCmpnop:p_dsCmpqrs:p_dsCmpuvw)

p populateGeneralRisks...
p                 b                   Export
d populateGeneralRisks...
d                 pi              N
d pClientNo                           like(dsxxxCmpabc_Template.cltkyh)
d                                     const
d pBranchCode                         like(dsxxxCmphdr_File.wtdbrh)
d                                     const
d pProductCode                        like(dsxxxCmphdr_File.wtdtyh)
d                                     const
d pCompanyNo                          like(dsxxxCmphdr_File.Cmpnoh)
d                                     const
d p_dsCmpabc                          likeds(dsCmpabc_Template)
d p_dsCmpdef                          likeds(dsCmpdef_Template)
d p_dsCmpghi                          likeds(dsCmpghi_Template)
d p_dsCmpklm                          likeds(dsCmpklm_Template)
d p_dsCmpnop                          likeds(dsCmpnop_Template)
d p_dsCmpqrs                         likeds(dsCmpqrs_Template)
d p_dsCmpuvw                          likeds(dsCmpuvw_Template)
d dsRequestIn                         likeds(Company_Template)
d p_errorDS                           LikeDS(dsAGHErrorInfo_Template)
*;

/Free
     clear p_dsCmpabc;
     clear p_dsCmpdef;
     clear p_dsCmpghi;
     clear p_dsCmpklm;
     clear p_dsCmpnop;
     clear p_dsCmpqrs;
     clear p_dsCmpuvw;




p_dsCmpabc.wtdbrr = dsRequestIn.Company.brands.brand.
                   branchcode;
p_dsCmpabc.wtdtyr= dsRequestIn.Company.brands.brand.
                   productcode;



p_dsCmpdef.wtdbrk = dsRequestIn.Company.brands.brand.
                    branchcode;

p_dsCmpdef.wtdtyk = dsRequestIn.Company.brands.brand.
                    productcode;

p_dsCmpdef.whobrk = dsRequestIn.Company.CompanyRisk.
                    bankruptcy.whobankrupt;
p_dsCmpdef.fstnmk = dsRequestIn.Company.CompanyRisk.
                    bankruptcy.firstname;

p_dsCmpghi.wtdbrb = dsRequestIn.Company.brands.brand.
                    branchcode;

p_dsCmpghi.wtdtyb = dsRequestIn.Company.brands.brand.
                    productcode;
p_dsCmpghi.scontb = dsRequestIn.Company.CompanyRisk.
                    ghiinessuse.selfcontainedoffice;

for i = 1 to %elem(brands_Template.brand);
p_dsCmpklm(i).wtdbre = dsRequestIn(i).Company.brands.brand.
                     branchcode;
p_dsCmpklm(i).wtdtye = dsRequestIn(i).Company.brands.brand.
                     productcode;
p_dsCmpklm(i).fielde = dsRequestIn(i).Company.CompanyRisk.
                     additionaldata.data.name;
p_dsCmpklm(i).valuee = dsRequestIn(i).Company.CompanyRisk.
                     additionaldata.data.value;

endfor;

p_dsCmpnop.wtdbrl = dsRequestIn.Company.brands.brand.
                    branchcode;
p_dsCmpnop.wtdtyl = dsRequestIn.Company.brands.brand.
                    productcode;
p_dsCmpnop.prvmsl = dsRequestIn.Company.CompanyRisk.
                    flooding.floodmeasurestaken;



p_dsCmpqrs.wtdbrf = dsRequestIn.Company.brands.brand.
                  branchcode;
p_dsCmpqrs.wtdtyf = dsRequestIn.Company.brands.brand.
                    productcode;
p_dsCmpuvw.wtdbrp = dsRequestIn.Company.brands.
                    brand.branchcode;
p_dsCmpuvw.wtdtyp = dsRequestIn.Company.brands.
                    brand.productcode;
p_dsCmpuvw.uvwyrp = dsRequestIn.Company.CompanyRisk.
                    underuvwned.date;
p_dsCmpuvw.propfp = dsRequestIn.Company.CompanyRisk.
                    underuvwned.proportionunderuvwned;


                if %error() ;
                   pErrorDS.error = *on ;
                   doError('AGH0005':pErrorDS);
                   return *off ;
                endif ;
                else;
                return *on;
                endif;


/End-Free
p                 e

========================
d Company_Template...
d                 ds                  qualified based(dummy_ptr)
d brands                              likeds(brands_Template)
d Companysource                         likeds(Companysource_Template)
d contact                             likeds(contact_Template)
d CompanyRisk                       likeds(CompanyRisk_Template)