× The internal search function is temporarily non-functional. The current search engine is no longer viable and we are researching alternatives.
As a stop gap measure, we are using Google's custom search engine service.
If you know of an easy to use, open source, search engine ... please contact support@midrange.com.



Code review is not just for technical standards or quality. In my shop the specs sometimes lack a technical detail or two about exactly how the data works for a file or something. Manager calls it "business knowledge", and it is that, but it's a bit of "gotcha experience" too. Way too much code base to know it all.


On 11/15/2011 5:52 PM, DeLong, Eric wrote:
Personally, I haven't seen much to recommend code reviews as an effective quality control. In my experience, the reviewer often will have reservations about coding structure or style, but if it produces the right result, then it just gets passed through. Additionally, I often see code reviews being conducted by developers with little or no experience with the applications in question. How effective can that be?

-Eric DeLong

-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of GKern@xxxxxxxxxxxxxxxx
Sent: Tuesday, November 15, 2011 4:30 PM
To: rpg400-l@xxxxxxxxxxxx
Subject: RE: Do you do formal code reviews? ( PDF Checklist )

"We simply have a checklist pdf. We mark them off if everything is good.
The attach the pdf to the change request."

Michael - care to share the contents of your PDF?

We have a new IT director here and he's mentioned code review. This might
be a good place to start.

Thanks, Jerry

Gerald Kern - Information Technology
Programming Supervisor
IBM Certified RPG IV Developer
Lotus Notes/Domino 8.0.1 Administrator
The Toledo Clinic, Inc.
4235 Secor Road
Toledo, OH 43623
Phone 419-479-5535
gkern@xxxxxxxxxxxxxxxx


This e-mail message, including any attachments, is for the sole use of the
intended recipient(s) and may contain confidential and privileged
information. Any unauthorized use, disclosure or distribution is
prohibited. If you are not the intended recipient, please inform the
sender by reply e-mail and destroy this and all copies of this message.
--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.





As an Amazon Associate we earn from qualifying purchases.

This thread ...

Replies:

Follow On AppleNews
Return to Archive home page | Return to MIDRANGE.COM home page

This mailing list archive is Copyright 1997-2024 by midrange.com and David Gibbs as a compilation work. Use of the archive is restricted to research of a business or technical nature. Any other uses are prohibited. Full details are available on our policy page. If you have questions about this, please contact [javascript protected email address].

Operating expenses for this site are earned using the Amazon Associate program and Google Adsense.