Re: Separate buisness and display logic question

One thing to consider is that reduced granularity in your functions leads to reduced usability. By writing the function to use a data structure, you are effectively locking the validation in to this single instance. If each field has it's own validation routine you can reuse the routine virtually anywhere that field needs to be validated.

The upside of increased granularity is reduced code and maintenance. The downside of increased granularity is increased processing time and impact analysis. Take your pick.

Mark Murphy
STAR BASE Consulting, Inc.
mmurphy@xxxxxxxxxxxxxxx

-----rpg400-l-bounces@xxxxxxxxxxxx wrote: -----
To: "RPG programming on the IBM i / System i" <rpg400-l@xxxxxxxxxxxx>
From: Charles Wilt
Sent by: rpg400-l-bounces@xxxxxxxxxxxx
Date: 02/02/2011 10:51AM
Subject: Re: Separate buisness and display logic question

Another option would be to provide some way for an error DS that
returned a field name + an error message (ID).

This would allow your process to return multiple message for any given field.

Charles

On Wed, Feb 2, 2011 at 8:11 AM, David FOXWELL <David.FOXWELL@xxxxxxxxx> wrote:

Hi all,

A program displays 5 fields concerning a client's bank details. A procedure exists that accepts these details as a DS and checks each field.

eg:


D CheckBankDetails...
D                    PI       N
D BankDetails                       likeds(refDS) const
D error                             like(refError)


 /free
       If BankDetails.AccountNumber <> etc
               error = 'etc..'
               return *off
       endif

       If BankDetails.BankCode <> etc
               error = 'etc..'
               return *off
       endif
/end-free

Caller : IF not CheckBankDetails ( DSBank );
               //Now what?
          Endif;

On returning from this procedure, how can the display manager program position the cursor on the first incorrectly filled information using an indicator and DSPATR(PC)?



Thanks.


--
This is the RPG programming on the IBM i / System i (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.