Re: subroutines are bug factories was: Classic Traps -- I need yourinput!

If a local variable name in a subprocedure is also in the main procedure, I
still say it leads to confusion, especially if nobody bothers to explain to
a new programmer (or an old one coming over from RPG III), that these two
are actually different variables.

On Mon, Mar 31, 2008 at 12:32 PM, Murphy, Mark <MurphyM@xxxxxxxxxx> wrote:

No, local variables do not make the code more bug prone because they are
only applicable to the
subprocedure, and since a subprocedure only does a single thing, it isn't
all that big. Therefore, a
subprocedure isn't terribly hard to read and understand. And since a
subprocedure only does a single
thing, and has no side-effects, it is easy to reuse wherever it is needed;
just like a BIF.

And no, global variables do not make code harder to read or modify; they
make code harder to reuse.
If your program is all there to see with nothing shared in a copybook,
global variables and
subroutines can be just as easy to read and maintain as a modern
application using subprocedures. In
some ways easier because the change you make in a program only affects
that one program. However, in
some ways this technique makes changes harder because you have to evaluate
and make the same change in
more places. It is all a give and take. There is no one right answer.

-----Original Message-----
From: rpg400-l-bounces@xxxxxxxxxxxx [mailto:rpg400-l-bounces@xxxxxxxxxxxx]
On Behalf Of Francis
Lapeyre
Sent: Monday, March 31, 2008 12:56 PM
To: RPG programming on the AS400 / iSeries
Subject: Re: subroutines are bug factories was: Classic Traps -- I need
yourinput!

Actually, in my opinion, it's the local variables that make code more
bug-prone. Why on earth do I need to keep track of what the variable is in
this or that procedure, anyway?

On Mon, Mar 31, 2008 at 11:38 AM, Steve Richter <stephenrichter@xxxxxxxxx>
wrote:

On Mon, Mar 31, 2008 at 12:18 PM, Bob P. Roche <BRoche@xxxxxxxxxxxxxxxxx

wrote:

But *PSSR is there to handle things that are unexpected. If an error

is

possibly expected, definitely use MONITOR. I also don't see the

problem

with *INZSR, why get rid of a subroutine, just because it s a

subroutine?

I agree there are times when *INZSR should not be used but just to

replace

it with a named procedure, just so you don't have a subroutine, I

don't

see the point. procedures and subroutines both have their uses.

Bob,

I dont think I have written a subroutine in /free, ever. The problem

with

subroutines is they require global variables. Globals are bugs waiting

to

happen. They make code very difficult to read and modify.
--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing

list

To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.

--
Francis Lapeyre

Da mihi sis crustum Etruscum cum omnibus in eo.
--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.


This e-mail transmission contains information that is intended to be
confidential and privileged. If you receive this e-mail and you are not a
named addressee you are hereby notified that you are not authorized to read,
print, retain, copy or disseminate this communication without the consent of
the sender and that doing so is prohibited and may be unlawful. Please
reply to the message immediately by informing the sender that the message
was misdirected. After replying, please delete and otherwise erase it and
any attachments from your computer system. Your assistance in correcting
this error is appreciated.
--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing
list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.