Re: Matching Records - End Product

Agreed. It is structured and logical (not always the same thing). Terri even got it right that the data from the secondary file (02) is not available for comparison until the 02 record is read.

Writing Level Control Breaks may, as someone said, be "trivial", but matching records is far from a trivial exercise. It would take far less time for a newbie to grasp the concept of matching records than it would take to re-write it. And I doubt that such re-write would be as understandable. I used to work in a mixed Cobol / RPG shop. Any time matching record processing was needed, we always wrote those in RPG because it was simple, short, sweet, and understandable.


* Jerry C. Adams
*IBM System i Programmer/Analyst
B&W Wholesale Distributors, Inc.* *
voice
615.995.7024
fax
615.995.1201
email
jerry@xxxxxxxxxxxxxxx <mailto:jerry@xxxxxxxxxxxxxxx>



Michael Ryan wrote:

Speak for yourself...it's pretty readable to me.

On Dec 18, 2007 9:01 AM, Glenn Gundermann <ggundermann@xxxxxx> wrote:

Terri,

As long as nobody else ever has to maintain this, good for you.
The way it is now, it's unreadable.
The next person would have to re-write this, wasting time to test and thus
introducing the chance of creating a bug unnecessarily.

Glenn Gundermann
ggundermann@xxxxxx
(647) 272-3295

Hi,
I was the one who asked about the matching records. I have it in
place and it is working slick. The right tool for the job. Just for the
record, this is the core of my program. The subroutines call another
program that gets the detail and prints it.

FGLD490C1 IPE AF 62 DISK
FGLD490G1 ISE AF 70 DISK

IGLD490C1 AA 01
I 1 1 CTYPE
I P 2 4 0CYEAR M1
I P 5 6 0CPERD M2
I 7 16 CPFTC
I P 17 18 0CCSET
I 19 33 CPROD M3
I 34 35 CCLS
I P 36 40 CINV
I P 41 46 3CQTY
I P 47 54 2CCST
I P 55 62 4CNET
IGLD490G1 AB 02
I 1 1 GTYPE
I P 2 4 0GYEAR M1
I P 5 6 0GPERD M2
I 7 16 GPFTC
I P 17 18 0GCSET
I 19 33 GPROD M3
I 34 35 GCLS
I P 36 40 GINV
I P 41 46 3GQTY
I P 47 54 2GCST
I P 55 62 4GNET

C IF *IN01 = *ON or *IN02 = *ON
C*
C IF First = 'YES'
C EXSR Init
C ENDIF
C*
C SELECT
C WHEN *IN02 and *INMR and CCST = GCST
C* Do nothing. Item in both files & amounts match
C WHEN *IN02 and *INMR
C EXSR AmtDif
C WHEN *IN01 and NOT *INMR
C EXSR NMR01
C WHEN *IN02 and NOT *INMR
C EXSR NMR02
C ENDSL
C*
C ENDIF

Other than some D specs and the subroutines, that's it.

<===================================================>

Terri Harteau
Felker Brothers Corporation

--
This is the RPG programming on the AS400 / iSeries (RPG400-L) mailing list
To post a message email: RPG400-L@xxxxxxxxxxxx
To subscribe, unsubscribe, or change list options,
visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
or email: RPG400-L-request@xxxxxxxxxxxx
Before posting, please take a moment to review the archives
at http://archive.midrange.com/rpg400-l.