RE: SELECT & WHENEQ Question

["Wilt, Charles" <CWilt@xxxxxxxxxxxx>]

I was thinking about that myself.

IMHO, the answer is no.

You could certainly do it, but you'd have to short-circuit the for loop
with LEAVE since the for loop really isn't the controlling factor.
Plus you'd have to code to set W@GOOD to 'NO' if you make it all the way
through the loop.  The result is ugly, and not clear as to why your are
doing what you are doing.

For x = 30 downto 10 by 10;
  K@FAC = %char(x);
  W@GOOD = *BLANKS;
  EXSR $100
  if W@GOOD <> *BLANKS;
    leave;
  endif;
  W@GOOD = 'NO';
Endfor;


Well, I guess that's not as bad as I first envisioned. ;-)  But it seems
the original code checked '30','10','20'...does order matter?

Still, it seems to me that this is a little clearer as to what you are
doing:

K@FAC = '30';
exsr $100;
if W@GOOD = *BLANKS;
  K@FAC = '10';
  exsr $100;
  if W@GOOD = *BLANKS;
    K@FAC = '20';
    exsr $100;
    if W@GOOD = *BLANKS;
      W@GOOD = 'NO ';
    endif;
  Endif;
Endif;


Oh and Teri, if you're making changes for readability, please, please,
give subroutine $100 a decent name!


Charles Wilt
--
iSeries Systems Administrator / Developer
Mitsubishi Electric Automotive America
ph: 513-573-4343
fax: 513-398-1121
  

> -----Original Message-----
> From: rpg400-l-bounces@xxxxxxxxxxxx 
> [mailto:rpg400-l-bounces@xxxxxxxxxxxx] On Behalf Of Booth Martin
> Sent: Monday, August 14, 2006 1:14 PM
> To: RPG programming on the AS400 / iSeries
> Subject: Re: SELECT & WHENEQ Question
>
> Rick, would this be a place where using a for/endfor loop would help 
> clear up future confusion?
>
>
> rick baird wrote:
> > Terri,
> >
> > by removing the DOU, the change in K@FAC isn't re-checked.
> >
> > put the do back in, and it will return to the top of your 
> select and recheck.
> > Rick
> >
> > On 8/14/06, THarteau@xxxxxxxxxxxxxxxxxx 
> <THarteau@xxxxxxxxxxxxxxxxxx> wrote:
> > > Hi,
> > >      I am rewriting an old program. It has the following 
> chunk of code:
> > > C                 MOVE        '30'          K@FAC
> > > C     W@GOOD      DOUNE *BLANK
> > > C                 SELECT
> > > C     K@FAC       WHENEQ      '30'
> > > C                 EXSR        $100
> > > C     W@GOOD      IFEQ        *BLANK
> > > C                 MOVE        '10'          K@FAC
> > > C                 ENDIF
> > > C     K@FAC WHENEQ      '10'
> > > C                 EXSR        $100
> > > C     W@GOOD      IFEQ        *BLANK
> > > C                 MOVE        '20'          K@FAC
> > > C                 ENDIF
> > > C     K@FAC       WHENEQ      '20'
> > > C                 EXSR        $100
> > > C     W@GOOD      IFEQ         *BLANK
> > > C                 MOVE        'NO '         W@GOOD
> > > C                 ENDIF
> > > C                 ENDSL
> > > C                 ENDDO
> > >
> > > Basically, it is trying to find the correct bill of 
> material facility. It
> > > could be in 30, 10 or 20.  I changed it a bit for readability.
> > >
> > > C                 MOVE        *BLANK      W@GOOD
> > > C                 MOVE        '30'        K@FAC
> > > C                 SELECT
> > > C*
> > > C     K@FAC       WHENEQ      '30'
> > > C                 EXSR        $100
> > > C                 IF          W@GOOD = *BLANK
> > > C                 MOVE        '10'        K@FAC
> > > C                 ENDIF
> > > C     K@FAC WHENEQ      '10'
> > > C                 EXSR        $100
> > > C                 IF          W@GOOD = *BLANK
> > > C                 MOVE        '20'        K@FAC
> > > C                 ENDIF
> > > C     K@FAC WHENEQ      '20'
> > > C                 EXSR        $100
> > > C                 IF          W@GOOD = *BLANK
> > > C                 MOVE        'NO '       W@GOOD
> > > C                 ENDIF
> > > C*
> > > C                 ENDSL
> > > C*
> > >
> > > When I put it in debug, it does the first WHEN, changes 
> K@FAC to '10', goes
> > > to the next WHENEQ, then goes to the ENDSL.  Can anyone 
> tell me why it no
> > > longer works?
> > >
> > > <===================================================>
> > >
> > > Terri Harteau
> > > Programmer/Analyst
> > > Felker Brothers Corporation
> > > ****************
> > > "The danger in life is not that we aim too high and miss.
> > > The problem is that we aim too low and hit the mark."  -- 
> Michelangelo
> > > ****************
> > >
> > >
> > >
> > >
> > > --
> > > This is the RPG programming on the AS400 / iSeries 
> (RPG400-L) mailing list
> > > To post a message email: RPG400-L@xxxxxxxxxxxx
> > > To subscribe, unsubscribe, or change list options,
> > > visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> > > or email: RPG400-L-request@xxxxxxxxxxxx
> > > Before posting, please take a moment to review the archives
> > > at http://archive.midrange.com/rpg400-l.
>
> -- 
> -----------------------------
> Booth Martin
> www.martinvt.com
> -----------------------------
> -- 
> This is the RPG programming on the AS400 / iSeries (RPG400-L) 
> mailing list
> To post a message email: RPG400-L@xxxxxxxxxxxx
> To subscribe, unsubscribe, or change list options,
> visit: http://lists.midrange.com/mailman/listinfo/rpg400-l
> or email: RPG400-L-request@xxxxxxxxxxxx
> Before posting, please take a moment to review the archives
> at http://archive.midrange.com/rpg400-l.