Re: QSYGETPH API -- RPG400-L

I've posted our code below.  Does anyone see anything obvious we might
be doing wrong ?

Yes, very obvious. You're passing a pointer instead of a character fieldfor the password!!


Here's your prototype:

    D GetProfile      Pr                    ExtPgm('QSYGETPH')
    D  UserID                       10A
    D  Password                       *
    D  Handle                       12A
    D  ErrorCode                   256A   Options(*Varsize : *NoPass)
    D  PswLength                    10I 0 Options(*NoPass)
    D  CCSIDCode                    10I 0 Options(*NoPass)

The API documentation states that the 2nd parameter is a CHAR field, not apointer. Instead of passing a string containing the password, you'repassing a memory address to the API. The API is reading that memoryaddress, and thinking that you're intending that 16-byte hex value (theaddress) to be the password.

For example, when the subprocedure starts, the program needs memory forthe "password" variable (it gets it's own memory, since it's passed byvalue.) The program asks the operating system for 10 bytes of the memory,and the os says (for example) that it can use 10 bytes starting withmemory address x'8000000000000000C655098D43073340'.

It then copies this address to the passwordin variable -- and passes thatnumber, x'8000000000000000C655098D43073340', instead of the actualpassword, to the API. The API thinks that this number is supposed to bethe password -- and tries it, only to find that it's not the rightpassword for the userid.


Change your prototype to look like this:

    D GetProfile      Pr                    ExtPgm('QSYGETPH')
    D  UserID                       10A   const
    D  Password                  32767A   const options(*varsize)
    D  Handle                       12A
    D  ErrorCode                   256A   Options(*Varsize : *NoPass)
    D  PswLength                    10I 0 const Options(*NoPass)
    D  CCSIDCode                    10I 0 const Options(*NoPass)

Note that in addition to coding the password as a character field, I alsomade the input-only fields be "const". This'll make the API easier tocall in many situations, it's also more self-documenting.


When you call it, do this:

        //?Retrieve user Profile;

             CallP  GetProfile( %late(LC:UC:UserID)
                              : password
                              : handle
                              : ERRDS:
                              : %len(password)
                              : 0 );

Note that because I used CONST on the prototype, I can do somecalculations on the call to the API. This makes the code shorter,eliminates the need for temporary one-use variables, and IMHO it's easierto read, because I mentally look at the call and say "Call with uppercaseuserid, call with the length of the password field", etc. If you putvariables there, I have to go back and examine them to see what you did tothem.

I also changed your CCSID from 37 to 0. 37 means that it'll always beEBCDIC for English languages in the USA. If this code is ever runelsewhere, the fact that this is hard-coded might screw someone up.Changing it to 0 tells it to retrieve the job's CCSID value and use that.That's usually a better choice for the default.

But, all of these are just "tips" for improvement. The actual error isthe fact that you're passing a pointer instead of a character field forthe password.