RE: Why is LEAVE bad? (was: Cycle Processing vs. Doing it my way)

[Buck Calabro <Buck.Calabro@xxxxxxxxxxxx>]

>To write 10,000 lines of code to avoid a goto/leave/iter/leavsr verses
>putting a leave in place to pop out of a loop, go to the top of a loop,
>or leaving a subroutine is a little pointless.

Like I said, I use LEAVE, but I try to be thoughtful about it.

I humbly maintain that counting source statements is an inadequate means of
judging the quality of that code.  Certainly the larger the codebase, the
greater the probability of errors, but I would say that there are many
instances where more source statements are better.  For just one practical
example:

movea '000000' *in(40)

vs.

D@Indicators      S               *   Inz(%addr(*in))
DIndicators       DS                  Based(@Indicators)
D SflClr                 40     40
D SflDsp                 41     41
D SflDspCtl              42     42
D AllowRollUp            43     43
D SflNxtChg              44     44
D FldErrFlag             45     45

eval sflclr = *off
eval sfldsp = *off
eval sfldspctl = *off
eval allowrollup = *off
eval sflnxtchg = *off
eval flderrflag = *off

  --buck